Bug 1218451

Summary: bison: clarify parameter declaration
Product: [openSUSE] openSUSE Tumbleweed Reporter: Michal Suchanek <msuchanek>
Component: DevelopmentAssignee: Michael Matz <matz>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: proposed patch

Description Michal Suchanek 2023-12-29 12:53:09 UTC
Created attachment 871602 [details]
proposed patch

Patch clarifying parameter declarations.
Comment 1 Richard Biener 2024-01-08 09:58:07 UTC
upstream?
Comment 2 Michal Suchanek 2024-01-08 12:24:00 UTC
Have not done the paperwork for talking to GNU upstream.
Comment 3 Michael Matz 2024-01-08 16:20:26 UTC
Doesn't this already follow from the use of singular form in

   Directive: %parse-param {ARGUMENT-DECLARATION} ...

and the example that uses two arguments with separate braces:

   %parse-param {int *nastiness} {int *randomness}

?  I guess being more explicit doesn't hurt, though.
Comment 4 Michal Suchanek 2024-01-08 17:11:55 UTC
It's kind of 'if you know how it is you can see it there' thing.

As in if you have no idea how it's implemented internally it's not clear at all.
Comment 5 Michal Suchanek 2024-01-08 17:14:32 UTC
The other option would be bison refusing multiple arguments in one %parse-param but it does not. Documenting the deficiency sounds easier than fixing it.