Bug 1218584 (CVE-2024-21885)

Summary:	VUL-0: CVE-2024-21885: xorg-x11-server,xwayland: Heap buffer overflow in XISendDeviceHierarchyEvent
Product:	[Novell Products] SUSE Security Incidents	Reporter:	SMASH SMASH <smash_bz>
Component:	Incidents	Assignee:	Security Team bot <security-team>
Status:	RESOLVED FIXED	QA Contact:	Security Team bot <security-team>
Severity:	Major
Priority:	P3 - Medium	CC:	gabriele.sonnu, meissner, sndirsch, stoyan.manolov
Version:	unspecified
Target Milestone:	---
Hardware:	Other
OS:	Other
URL:	https://smash.suse.de/issue/390191/
Whiteboard:	CVSSv3.1:SUSE:CVE-2024-21885:8.4:(AV:L/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H)
Found By:	Security Response Team	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description SMASH SMASH 2024-01-07 16:31:23 UTC

CRD: 2024-01-16
via xorg-security

3) CVE-2024-21885: Heap buffer overflow in XISendDeviceHierarchyEvent

Introduced in: xorg-server-1.10.0 (2011)
Fixed in: xorg-server-21.1.11 and xwayland-23.2.4
Fix:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/033a2b12fcd02fa9a2c2f20a352bec0a43074512
Found by: Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

The XISendDeviceHierarchyEvent() function allocates space to store up
to MAXDEVICES (256) xXIHierarchyInfo structures in info.

If a device with a given ID was removed and a new device with the same
ID added both in the same operation, the single device ID will lead to
two info structures being written to info.

Since this case can occur for every device ID at once, a total of two
times MAXDEVICES info structures might be written to the allocation,
leading to a heap buffer overflow.

xorg-server-21.1.11 and xwayland-23.2.4 have been patched to fix this issue.

Comment 2 Stefan Dirsch 2024-01-08 14:32:14 UTC

I've submitted now xorg-x11-server and xwayland packages for 

sle12-sp5
sle15-sp2
sle15-sp4
sle15-sp5

I will take care of packages for ALP, sle15-sp6 and X11:XOrg/factory/Tumbleweed once the security update has been officially released.

Comment 4 Gabriele Sonnu 2024-01-16 12:33:53 UTC

Public now:

https://lists.x.org/archives/xorg/2024-January/061525.html

3) CVE-2024-21885: Heap buffer overflow in XISendDeviceHierarchyEvent

Introduced in: xorg-server-1.10.0 (2011)
Fixed in: xorg-server-21.1.11 and xwayland-23.2.4
Fix: https://gitlab.freedesktop.org/xorg/xserver/-/commit/4a5e9b1895627d40d26045bd0b7ef3dce503cbd1
Found by: Jan-Niklas Sohn working with Trend Micro Zero Day Initiative

The XISendDeviceHierarchyEvent() function allocates space to store up
to MAXDEVICES (256) xXIHierarchyInfo structures in info.

If a device with a given ID was removed and a new device with the same
ID added both in the same operation, the single device ID will lead to
two info structures being written to info.

Since this case can occur for every device ID at once, a total of two
times MAXDEVICES info structures might be written to the allocation,
leading to a heap buffer overflow.

xorg-server-21.1.11 and xwayland-23.2.4 have been patched to fix this issue.

Comment 6 Stefan Dirsch 2024-01-16 14:33:30 UTC

Security update for xwayland now done in X11:XOrg devel project. Packages now submitted for factory/Tumbleweed, ALP and sle15-sp6.

Security update for xwayland now done in X11:XOrg devel project. Packages now submitted for factory/Tumbleweed and ALP.
SP6 inherits xorg-x11-server from sle15-sp6, for which I already submitted the fixes.

Reassigning to security team.

Comment 8 OBSbugzilla Bot 2024-01-16 15:35:08 UTC

This is an autogenerated message for OBS integration:
This bug (1218584) was mentioned in
https://build.opensuse.org/request/show/1139166 Factory / xwayland

Comment 9 OBSbugzilla Bot 2024-01-16 17:35:06 UTC

This is an autogenerated message for OBS integration:
This bug (1218584) was mentioned in
https://build.opensuse.org/request/show/1139223 Factory / xorg-x11-server

Comment 11 OBSbugzilla Bot 2024-01-16 23:35:08 UTC

This is an autogenerated message for OBS integration:
This bug (1218584) was mentioned in
https://build.opensuse.org/request/show/1139316 Factory / xwayland

Comment 13 OBSbugzilla Bot 2024-01-17 11:35:03 UTC

This is an autogenerated message for OBS integration:
This bug (1218584) was mentioned in
https://build.opensuse.org/request/show/1139423 Factory / xwayland

Comment 14 Maintenance Automation 2024-01-17 12:36:23 UTC

SUSE-SU-2024:0121-1: An update that solves four vulnerabilities can now be installed.

Category: security (important)
Bug References: 1218582, 1218583, 1218584, 1218585
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-21885, CVE-2024-21886
Sources used:
SUSE Linux Enterprise High Performance Computing 15 SP2 LTSS 15-SP2 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise High Performance Computing ESPOS 15 SP3 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise High Performance Computing LTSS 15 SP3 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Desktop 15 SP4 LTSS 15-SP4 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Server 15 SP2 LTSS 15-SP2 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Server 15 SP3 LTSS 15-SP3 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Server for SAP Applications 15 SP2 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Server for SAP Applications 15 SP3 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Linux Enterprise Workstation Extension 15 SP5 (src): xorg-x11-server-1.20.3-150200.22.5.88.1
SUSE Enterprise Storage 7.1 (src): xorg-x11-server-1.20.3-150200.22.5.88.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 15 Maintenance Automation 2024-01-17 12:36:30 UTC

SUSE-SU-2024:0116-1: An update that solves four vulnerabilities can now be installed.

Category: security (important)
Bug References: 1218582, 1218583, 1218584, 1218585
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-21885, CVE-2024-21886
Sources used:
SUSE Linux Enterprise High Performance Computing 12 SP5 (src): xorg-x11-server-1.19.6-10.65.1
SUSE Linux Enterprise Server 12 SP5 (src): xorg-x11-server-1.19.6-10.65.1
SUSE Linux Enterprise Server for SAP Applications 12 SP5 (src): xorg-x11-server-1.19.6-10.65.1
SUSE Linux Enterprise Software Development Kit 12 SP5 (src): xorg-x11-server-1.19.6-10.65.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 16 Maintenance Automation 2024-01-17 12:36:32 UTC

SUSE-SU-2024:0114-1: An update that solves four vulnerabilities can now be installed.

Category: security (important)
Bug References: 1218582, 1218583, 1218584, 1218585
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-21885, CVE-2024-21886
Sources used:
openSUSE Leap 15.5 (src): xwayland-22.1.5-150500.7.14.1
SUSE Linux Enterprise Workstation Extension 15 SP5 (src): xwayland-22.1.5-150500.7.14.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 17 Maintenance Automation 2024-01-17 12:36:46 UTC

SUSE-SU-2024:0111-1: An update that solves four vulnerabilities and has two security fixes can now be installed.

Category: security (important)
Bug References: 1218176, 1218240, 1218582, 1218583, 1218584, 1218585
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-21885, CVE-2024-21886
Sources used:
openSUSE Leap 15.4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise High Performance Computing ESPOS 15 SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise High Performance Computing LTSS 15 SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise Real Time 15 SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise Desktop 15 SP4 LTSS 15-SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise Server 15 SP4 LTSS 15-SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Linux Enterprise Server for SAP Applications 15 SP4 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Manager Proxy 4.3 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Manager Retail Branch Server 4.3 (src): xorg-x11-server-1.20.3-150400.38.40.1
SUSE Manager Server 4.3 (src): xorg-x11-server-1.20.3-150400.38.40.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 18 Maintenance Automation 2024-01-17 12:36:52 UTC

SUSE-SU-2024:0109-1: An update that solves four vulnerabilities and has two security fixes can now be installed.

Category: security (important)
Bug References: 1218176, 1218240, 1218582, 1218583, 1218584, 1218585
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-21885, CVE-2024-21886
Sources used:
openSUSE Leap 15.5 (src): xorg-x11-server-21.1.4-150500.7.18.1
Basesystem Module 15-SP5 (src): xorg-x11-server-21.1.4-150500.7.18.1
Development Tools Module 15-SP5 (src): xorg-x11-server-21.1.4-150500.7.18.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.

Comment 20 Maintenance Automation 2024-01-19 12:30:01 UTC

SUSE-SU-2024:0165-1: An update that solves six vulnerabilities can now be installed.

Category: security (important)
Bug References: 1218582, 1218583, 1218584, 1218585, 1218845, 1218846
CVE References: CVE-2023-6816, CVE-2024-0229, CVE-2024-0408, CVE-2024-0409, CVE-2024-21885, CVE-2024-21886
Sources used:
openSUSE Leap 15.4 (src): xwayland-21.1.4-150400.3.31.1
SUSE Linux Enterprise Desktop 15 SP4 LTSS 15-SP4 (src): xwayland-21.1.4-150400.3.31.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.