Bug 1219733

We're preparing a binutils update to version 2.42 in openSUSE:Factory:Staging:A
( https://build.opensuse.org/request/show/1144349 ), and qemu-ipxe assembly
sources hit a problem there:

[ 3712s] gcc -E -DARCH=x86_64 -DPLATFORM=efi -DSECUREBOOT=0 -fstrength-reduce -fomit-frame-pointer -falign-jumps=1 -falign-loops=1 -falign-functions=1 -m64 -mno-mmx -mno-sse -fshort-wchar -Ui386 -Ulinux -DNVALGRIND -fpie -mno-red-zone -fstack-protector-strong  -mstack-protector-guard=global -Iinclude -I. -Iarch/x86/include -Iarch/x86_64/include -Iarch/x86_64/include/efi -Os -g -ffreestanding -fcommon -Wall -W -Wformat-nonliteral -fno-dwarf2-cfi-asm -fno-exceptions  -fno-unwind-tables -fno-asynchronous-unwind-tables -Wno-address -Wno-stringop-truncation -Wno-address-of-packed-member -Wno-array-bounds -Wno-dangling-pointer  -Werror -ffunction-sections  -include include/compiler.h -DASM_TCHAR='@' -DASM_TCHAR_OPS='@' -DCONFIG=qemu -DLOCAL_CONFIG=qemu -DASSEMBLY  -DOBJECT=stack arch/x86/core/stack.S | as --64 --divide  --fatal-warnings -o bin-x86_64-efi/stack.o
[ 3712s] arch/x86/core/stack.S: Assembler messages:
[ 3712s] arch/x86/core/stack.S:3: Warning: 64bit mode not supported on `i386' (consider swapping .arch and .code directives).
[ 3712s] {standard input}: Error: 1 warning, treating warnings as errors

The problem (see below) is newly diagnosed, from upstream it's an error.  I made
binutils only emit a warning for this (as also other packages hit this), but
unfortunately qemu iPXE sources are built with --fatal-warnings, so the demotion
to warnings doesn't help here.

The problem is the following.  Assembly files using the '.arch i386' directive
need to have their code-size set _beforehand_ to either 32bit or 16bit.  The
'--64' cmdline argument sets it to 64bit resulting in the error message.  You
cannot get rid of this cmdline argument (or replace it with --32) because then
a different kind of ELF object file would be generated.

So, what needs to happen is for such code:

   .arch i386
   ... other directives ...
   .code16  # or .code32

to move (or add) the .codeXX directive in front of the .arch directive.

I will momentarily attach a patch to do that in all files from the roms/ipxe
subdir.  I've verified that this fixes the error message and lets qemu 8.2.0
build with the new binutils.  Tumbleweed (or at least the Staging:A) still
uses qemu 8.1.something, but as the iPXE repo gets virtually no changes at all
the patch should also apply to that tree as is.

(The build-test happens in home:matz2:branches:Virtualization/qemu/15.5 )

Can I convince someone from the qemu team to please integrate this patch into
the qemu package for at least tumbleweed?