Bug 1219800

You need to enable the debug repository to install filezilla-debuginfo-3.66.5-1.1.x86_64.rpm

https://download.opensuse.org/debug/tumbleweed/repo/oss/x86_64/filezilla-debuginfo-3.66.5-1.1.x86_64.rpm

Thank you. The trace is:

Thread 21 "filezilla" received signal SIGABRT, Aborted.
[Switching to Thread 0x7fffeaa006c0 (LWP 6241)]
0x00007ffff66949ec in __pthread_kill_implementation () from /lib64/libc.so.6

I test it in newest Tumbleweed VM.
When i use Version 3.66.5 from Tumbleweed it will crash at upload.
When i use Version 3.66.5 from my home repo all run well. No crash.
Think build should be retriggert.
Can someone do this?

Today FileZilla was updated again, this time to v. 3.66.5-2.1. The problem however persists.

I can confirm the problem, Filezilla crashes when I try to upload a file.

Same as last time.
When i install it from my home it runs without error.
When i install it from fatory/tumbleweed it crash.
But it is not the fillezila package itself.
It is with libfilezilla.
Don't know what different since some weeks.
Please rebuild it again.

> Please rebuild it again.

How is this supposed to go? How to let the relevant people know that libfilezilla needs to be rebuilt?

(In reply to Hernán De Angelis from comment #7)
> > Please rebuild it again.
> 
> How is this supposed to go? How to let the relevant people know that
> libfilezilla needs to be rebuilt?

In which someone reads along here who has the right to do so. 
It was successful last time. Didn't it?

(In reply to Eric Schirra from comment #8)
> (In reply to Hernán De Angelis from comment #7)
> > > Please rebuild it again.
> > 
> > How is this supposed to go? How to let the relevant people know that
> > libfilezilla needs to be rebuilt?
> 
> In which someone reads along here who has the right to do so. 
> It was successful last time. Didn't it?

If I use filezilla and libfilezilla from you repository it works.

I've tried to branch current factory packages (both filezilla and libfilezilla)  and if I install these packages it crashes.

The difference could then be in one of these packages:

osc dependson home:ecsos libfilezilla openSUSE_Tumbleweed x86_64
libfilezilla :
      autoconf
      gmp
      libnettle
      p11-kit

osc dependson home:ecsos filezilla openSUSE_Tumbleweed x86_64
filezilla :
      autoconf
      boost:base
      brotli
      freetype2
      fribidi
      gmp
      libXrandr
      libfilezilla
      libjpeg-turbo
      libjpeg62-turbo
      libnettle
      libvorbis
      opus
      p11-kit
      pugixml
      timezone
      wxWidgets-3_2
      wxWidgets-3_2:GTK3

(In reply to Andreas Stieger from comment #10)
> The difference could then be in one of these packages:
> 
> osc dependson home:ecsos libfilezilla openSUSE_Tumbleweed x86_64
> osc dependson home:ecsos filezilla openSUSE_Tumbleweed x86_64

Super. 
I didn't know that yet either.
I'll see if I can find a reason why it works for me and sometimes not in Factory.

I had written that replacing libfilezilla solved the problem.
If I use the results of the query for libfilezilla and then query it, only gmp is returned.
And here the only difference is the adjustments because of RPM 4.2
So that doesn't help me either. :-(

I have the same problem, can't upload any files anymore, any hope of a solution?

(In reply to David Kerkhof from comment #13)
> I have the same problem, can't upload any files anymore, any hope of a
> solution?

In the meanwhile you can use ftp from the command line. It is really not difficult to learn and use.

(In reply to Hernán De Angelis from comment #14)
> (In reply to David Kerkhof from comment #13)
> > I have the same problem, can't upload any files anymore, any hope of a
> > solution?
> 
> In the meanwhile you can use ftp from the command line. It is really not
> difficult to learn and use.

You are right, so I did, lftp in my case because I needed ftps, works ok, thanks for the tip

first, a backtrace:

(gdb) bt
#0  0x00007faed70949ec in __pthread_kill_implementation () at /lib64/libc.so.6
#1  0x00007faed7041176 in raise () at /lib64/libc.so.6
#2  0x00007faed7028917 in abort () at /lib64/libc.so.6
#3  0x00007faed889dbb2 in fz::nonowning_buffer::add(unsigned long) (this=<optimized out>, bytes=<optimized out>)
    at /usr/src/debug/libfilezilla-0.46.0/lib/nonowning_buffer.cpp:38
#4  0x00007faed88a77b4 in fz::file_reader::entry() (this=0x7faea4078fa0) at aio/../libfilezilla/aio/aio.hpp:43
#5  operator() (__closure=<optimized out>) at aio/reader.cpp:289
#6  std::__invoke_impl<void, fz::file_reader::do_seek(fz::scoped_lock&)::<lambda()>&> (__f=<optimized out>)
    at /usr/include/c++/13/bits/invoke.h:61
#7  std::__invoke_r<void, fz::file_reader::do_seek(fz::scoped_lock&)::<lambda()>&> (__fn=<optimized out>)
    at /usr/include/c++/13/bits/invoke.h:111
#8  std::_Function_handler<void(), fz::file_reader::do_seek(fz::scoped_lock&)::<lambda()> >::_M_invoke(const std::_Any_data &)
    (__functor=<optimized out>) at /usr/include/c++/13/bits/std_function.h:290
#9  0x00007faed88ecb87 in std::function<void ()>::operator()() const (this=0x7faea4067d18)
    at /usr/include/c++/13/bits/std_function.h:591
#10 fz::pooled_thread_impl::entry() (this=0x7faea4067d00) at /usr/src/debug/libfilezilla-0.46.0/lib/thread_pool.cpp:40
#11 0x00007faed74ec344 in  () at /lib64/libstdc++.so.6
#12 0x00007faed7092bb2 in start_thread () at /lib64/libc.so.6
#13 0x00007faed711400c in clone3 () at /lib64/libc.so.6
(gdb) frame 3
#3  0x00007faed889dbb2 in fz::nonowning_buffer::add (this=<optimized out>, bytes=<optimized out>)
    at /usr/src/debug/libfilezilla-0.46.0/lib/nonowning_buffer.cpp:38
38			abort();
(gdb) frame 4
#4  0x00007faed88a77b4 in fz::file_reader::entry (this=0x7faea4078fa0) at aio/../libfilezilla/aio/aio.hpp:43
43		nonowning_buffer* operator->() { return &buffer_; }


the abort is triggered by the code itself (ouch)

void nonowning_buffer::add(size_t bytes)
{
        if (capacity_ - start_ - size_ < bytes) {
                abort();
        }
        size_ += bytes;
}

This in turn looks very much like this upstream fix:

https://svn.filezilla-project.org/filezilla/libfilezilla/trunk/lib/aio/reader.cpp?view=patch&r1=11064&r2=11095&sortby=date


After taddin this patch to a local build, I was able to upload files using FileZilla (crashed before)

created an SR to the devel project:

> osc rq list
1162938  State:new        By:dimstar      When:2024-03-27T15:14:56
        Created by: dimstar
        submit:          home:dimstar:Factory/libfilezilla@2 ->             network
        Descr: - Add libfilezilla-fix-crash.patch: Fix crash when uploading
               files   (boo#1219800).

This is an autogenerated message for OBS integration:
This bug (1219800) was mentioned in
https://build.opensuse.org/request/show/1162955 Factory / libfilezilla

Request was accepted for Factory.