Bug 1220246 (CVE-2024-26587)

Summary: VUL-0: CVE-2024-26587: kernel-source,kernel-source-azure,kernel-source-rt: net: netdevsim: NULL pointer dereference when destroying uninitialized PHC
Product: [Novell Products] SUSE Security Incidents Reporter: SMASH SMASH <smash_bz>
Component: IncidentsAssignee: Security Team bot <security-team>
Status: RESOLVED FIXED QA Contact: Security Team bot <security-team>
Severity: Normal    
Priority: P5 - None CC: carlos.lopez, denis.kirjanov
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://smash.suse.de/issue/394909/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-26587:5.5:(AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H)
Found By: Security Response Team Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description SMASH SMASH 2024-02-23 09:15:30 UTC
In the Linux kernel, the following vulnerability has been resolved:

net: netdevsim: don't try to destroy PHC on VFs

PHC gets initialized in nsim_init_netdevsim(), which
is only called if (nsim_dev_port_is_pf()).

Create a counterpart of nsim_init_netdevsim() and
move the mock_phc_destroy() there.

This fixes a crash trying to destroy netdevsim with
VFs instantiated, as caught by running the devlink.sh test:

    BUG: kernel NULL pointer dereference, address: 00000000000000b8
    RIP: 0010:mock_phc_destroy+0xd/0x30
    Call Trace:
     <TASK>
     nsim_destroy+0x4a/0x70 [netdevsim]
     __nsim_dev_port_del+0x47/0x70 [netdevsim]
     nsim_dev_reload_destroy+0x105/0x120 [netdevsim]
     nsim_drv_remove+0x2f/0xb0 [netdevsim]
     device_release_driver_internal+0x1a1/0x210
     bus_remove_device+0xd5/0x120
     device_del+0x159/0x490
     device_unregister+0x12/0x30
     del_device_store+0x11a/0x1a0 [netdevsim]
     kernfs_fop_write_iter+0x130/0x1d0
     vfs_write+0x30b/0x4b0
     ksys_write+0x69/0xf0
     do_syscall_64+0xcc/0x1e0
     entry_SYSCALL_64_after_hwframe+0x6f/0x77

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-26587
https://git.kernel.org/stable/c/08aca65997fb6f233066883b1f1e653bcb1f26ca
https://git.kernel.org/stable/c/c5068e442eed063d2f1658e6b6d3c1c6fcf1e588
https://git.kernel.org/stable/c/ea937f77208323d35ffe2f8d8fc81b00118bfcda
https://www.cve.org/CVERecord?id=CVE-2024-26587
Comment 1 Carlos López 2024-02-23 09:16:51 UTC
We only have b63e78fca889 ("net: netdevsim: use mock PHC driver") in stable and master, which also have the fix, so we are not affected. Closing.