Bug 1220476

Summary:	GCC 14: freeipmi package fails
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Michal Jireš <michal.jires>
Component:	Other	Assignee:	Klaus Kämpf <kkaempf>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	kkaempf, mjambor
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1220571

Description Michal Jireš 2024-02-27 15:28:23 UTC

Building freeipmi with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/freeipmi/standard/x86_64

Due to:

sel/ipmi-sel-string-supermicro-x10dimm-common.c: In function ‘sel_string_output_supermicro_x10dimm_event_data2_event_data3’:
sel/ipmi-sel-string-supermicro-x10dimm-common.c:87:14: error: implicit declaration of function ‘sel_string_output_supermicro_dimm_event_data2_event_data3’; did you mean ‘sel_string_output_supermicro_x10dimm_event_data2_event_data3’? [-Wimplicit-function-declaration]
   87 |   if ((ret = sel_string_output_supermicro_dimm_event_data2_event_data3 (ctx,
      |              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |              sel_string_output_supermicro_x10dimm_event_data2_event_data3

ipmi-sensors-oem-intel.c: In function ‘ipmi_sensors_oem_intel_output_oem_record’:
ipmi-sensors-oem-intel.c:98:18: error: implicit declaration of function ‘ipmi_sensors_oem_intel_s2600wp_output_oem_record’; did you mean ‘ipmi_sensors_oem_intel_s2600jf_output_oem_record’? [-Wimplicit-function-declaration]
   98 |       if ((ret = ipmi_sensors_oem_intel_s2600wp_output_oem_record (state_data,
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                  ipmi_sensors_oem_intel_s2600jf_output_oem_record


Builds with:

Index: freeipmi.spec_dir/freeipmi-1.6.14/libfreeipmi/sel/ipmi-sel-string-supermicro-common.h
===================================================================
--- freeipmi.spec_dir.orig/freeipmi-1.6.14/libfreeipmi/sel/ipmi-sel-string-supermicro-common.h
+++ freeipmi.spec_dir/freeipmi-1.6.14/libfreeipmi/sel/ipmi-sel-string-supermicro-common.h
@@ -38,5 +38,14 @@ int sel_string_output_supermicro_overhea
                                                                  unsigned int flags,
                                                                  unsigned int *wlen,
                                                                  struct ipmi_sel_system_event_record_data *system_event_record_data);
+int sel_string_output_supermicro_dimm_event_data2_event_data3 (ipmi_sel_ctx_t ctx,
+                                                               struct ipmi_sel_entry *sel_entry,
+                                                               uint8_t sel_record_type,
+                                                               char *buf,
+                                                               unsigned int buflen,
+                                                               unsigned int flags,
+                                                               unsigned int *wlen,
+                                                               struct ipmi_sel_system_event_record_data *system_event_record_data,
+                                                               int *oem_rv);

 #endif /* IPMI_SEL_STRING_SUPERMICRO_COMMON_H */
Index: freeipmi.spec_dir/freeipmi-1.6.14/ipmi-sensors/ipmi-sensors-oem-intel.c
===================================================================
--- freeipmi.spec_dir.orig/freeipmi-1.6.14/ipmi-sensors/ipmi-sensors-oem-intel.c
+++ freeipmi.spec_dir/freeipmi-1.6.14/ipmi-sensors/ipmi-sensors-oem-intel.c
@@ -34,6 +34,7 @@
 #include "ipmi-sensors-oem-intel.h"
 #include "ipmi-sensors-oem-intel-s5500wb.h"
 #include "ipmi-sensors-oem-intel-s2600jf.h"
+#include "ipmi-sensors-oem-intel-s2600wp.h"
 #include "ipmi-sensors-oem-intel-quanta-qssc-s4r.h"
 #include "ipmi-sensors-oem-intel-node-manager.h"

Comment 1 Klaus Kämpf 2024-02-29 13:30:27 UTC

Known upstream: https://savannah.gnu.org/bugs/?65203

Comment 2 Klaus Kämpf 2024-03-07 13:18:15 UTC

https://build.opensuse.org/request/show/1155909

Comment 3 Martin Jambor 2024-05-31 19:22:19 UTC

The package is still failing, presumably because request 1155909 has been declined.

Comment 4 Klaus Kämpf 2024-06-03 14:46:11 UTC

(In reply to Martin Jambor from comment #3)
> The package is still failing, presumably because request 1155909 has been
> declined.

New request https://build.opensuse.org/request/show/1178346