Bug 1221008

Summary: GCC 14: musepack package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Michal Jireš <michal.jires>
Component: OtherAssignee: Michael Gorse <mgorse>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: mgorse
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Michal Jireš 2024-03-06 06:59:04 UTC
Building musepack with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/musepack/standard/x86_64

Due to (exhaustive list of errors):

musepack_src_r475/libmpcpsy/ans.c: In function ‘NS_Analyse’:
musepack_src_r475/libmpcpsy/ans.c:291:120: error: passing argument 10 of ‘FindOptimalANS’ from incompatible pointer type [-Wincompatible-pointer-types]
  291 |         FindOptimalANS ( MaxBand, MSflag, ANSspec_L, ANSspec_M, m->NS_Order_L, m->SNR_comp_L, m->FIR_L, smr.L, smr.M, m->SCF_Index_L, Transient );
      |                                                                                                                       ~^~~~~~~~~~~~~
      |                                                                                                                        |
      |                                                                                                                        int *
musepack_src_r475/libmpcpsy/ans.c:160:40: note: expected ‘const int (*)[3]’ but argument is of type ‘int *’
  160 |                  const int             scf [] [3],
      |                  ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
musepack_src_r475/libmpcpsy/ans.c:296:120: error: passing argument 10 of ‘FindOptimalANS’ from incompatible pointer type [-Wincompatible-pointer-types]
  296 |         FindOptimalANS ( MaxBand, MSflag, ANSspec_R, ANSspec_S, m->NS_Order_R, m->SNR_comp_R, m->FIR_R, smr.R, smr.S, m->SCF_Index_R, Transient );
      |                                                                                                                       ~^~~~~~~~~~~~~
      |                                                                                                                        |
      |                                                                                                                        int *

musepack_src_r475/mpcenc/mpcenc.c: In function ‘Quantisierung’:
musepack_src_r475/mpcenc/mpcenc.c:692:61: error: passing argument 1 of ‘QuantizeSubbandWithNoiseShaping’ from incompatible pointer type [-Wincompatible-pointer-types]
  692 |                 QuantizeSubbandWithNoiseShaping ( subq[Band].L, subx[Band].L, *resL, errorL [Band], m->FIR_L [Band] );
      |                                                   ~~~~~~~~~~^~
      |                                                             |
      |                                                             mpc_int16_t * {aka short int *}
In file included from /home/abuild/rpmbuild/BUILD/musepack_src_r475/mpcenc/mpcenc.c:27:
musepack_src_r475/mpcenc/mpcenc.h:258:56: note: expected ‘unsigned int *’ but argument is of type ‘mpc_int16_t *’ {aka ‘short int *’}
  258 | void   QuantizeSubbandWithNoiseShaping ( unsigned int* qu_output, const float* input, const int res, float* errors, const float* FIR );
      |                                          ~~~~~~~~~~~~~~^~~~~~~~~
musepack_src_r475/mpcenc/mpcenc.c:695:77: error: passing argument 1 of ‘QuantizeSubband’ from incompatible pointer type [-Wincompatible-pointer-types]
  695 |                                 QuantizeSubband                 ( subq[Band].L, subx[Band].L, *resL, errorL [Band], MAX_NS_ORDER );
      |                                                                   ~~~~~~~~~~^~
      |                                                                             |
      |                                                                             mpc_int16_t * {aka short int *}
musepack_src_r475/mpcenc/mpcenc.h:257:56: note: expected ‘unsigned int *’ but argument is of type ‘mpc_int16_t *’ {aka ‘short int *’}
  257 | void   QuantizeSubband                 ( unsigned int* qu_output, const float* input, const int res, float* errors, const int maxNsOrder );
      |                                          ~~~~~~~~~~~~~~^~~~~~~~~
musepack_src_r475/mpcenc/mpcenc.c:702:61: error: passing argument 1 of ‘QuantizeSubbandWithNoiseShaping’ from incompatible pointer type [-Wincompatible-pointer-types]
  702 |                 QuantizeSubbandWithNoiseShaping ( subq[Band].R, subx[Band].R, *resR, errorR [Band], m->FIR_R [Band] );
      |                                                   ~~~~~~~~~~^~
      |                                                             |
      |                                                             mpc_int16_t * {aka short int *}
musepack_src_r475/mpcenc/mpcenc.c:705:77: error: passing argument 1 of ‘QuantizeSubband’ from incompatible pointer type [-Wincompatible-pointer-types]
  705 |                                 QuantizeSubband                 ( subq[Band].R, subx[Band].R, *resR, errorL [Band], MAX_NS_ORDER);
      |                                                                   ~~~~~~~~~~^~
      |                                                                             |
      |                                                                             mpc_int16_t * {aka short int *}

See the meta bug#1220571 for more info.
Comment 1 Martin Jambor 2024-03-06 10:36:12 UTC
FTR, bug about the issue in Gentoo seems to be:
https://bugs.gentoo.org/919211
Comment 2 OBSbugzilla Bot 2024-03-11 21:35:02 UTC
This is an autogenerated message for OBS integration:
This bug (1221008) was mentioned in
https://build.opensuse.org/request/show/1157024 Factory / musepack
Comment 3 OBSbugzilla Bot 2024-03-12 13:35:02 UTC
This is an autogenerated message for OBS integration:
This bug (1221008) was mentioned in
https://build.opensuse.org/request/show/1157171 Factory / musepack
Comment 4 Michael Gorse 2024-03-14 22:36:53 UTC
Should be fixed in factory.