Bug 1221026

Summary: GCC 14: xdg-desktop-portal-gnome package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Michal Jireš <michal.jires>
Component: GNOMEAssignee: E-mail List <gnome-bugs>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: dimstar
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Michal Jireš 2024-03-06 08:43:21 UTC
Building xdg-desktop-portal-gnome with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/xdg-desktop-portal-gnome/standard/x86_64

Due to (exhaustive list of errors):

../src/inputcapture.c: In function ‘create_input_capture_dialog’:
../src/inputcapture.c:412:46: error: passing argument 2 of ‘gtk_window_group_add_window’ from incompatible pointer type [-Wincompatible-pointer-types]
  412 |   gtk_window_group_add_window (window_group, dialog);
      |                                              ^~~~~~
      |                                              |
      |                                              GtkWidget * {aka struct _GtkWidget *}
In file included from /usr/include/gtk-4.0/gtk/gtk.h:302,
                 from ../src/inputcapturedialog.h:21,
                 from ../src/inputcapture.c:22:
/usr/include/gtk-4.0/gtk/gtkwindowgroup.h:71:70: note: expected ‘GtkWindow *’ {aka ‘struct _GtkWindow *’} but argument is of type ‘GtkWidget *’ {aka ‘struct _GtkWidget *’}
   71 |                                                  GtkWindow          *window);
      |                                                  ~~~~~~~~~~~~~~~~~~~~^~~~~~

See the meta bug#1220571 for more info.
Comment 1 Martin Jambor 2024-03-06 10:49:35 UTC
FTR, the corresponding Gentoo bug seems to be:
https://bugs.gentoo.org/919079

and I believe that how Fedore tackles this issue is captured here:
https://gitlab.com/fweimer-rh/fedora-modernc/-/blob/main/pkg/x/xdg-desktop-portal-gnome.md?ref_type=heads
Comment 2 Dominique Leuenberger 2024-03-06 12:09:32 UTC
https://build.opensuse.org/projects/GNOME:Next/packages/xdg-desktop-portal-gnome/repositories/gcc14/binaries

46.rc seems to have successfully built against GCC 14