Bug 1221698

Summary: GCC 14: libcddb package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Michal Jireš <michal.jires>
Component: NetworkAssignee: Martin Schreiner <martin.schreiner>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: martin.schreiner, mcepl
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Michal Jireš 2024-03-19 12:06:52 UTC 
Building libcddb with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/libcddb/standard/x86_64

Due to (exhaustive list of errors):

cddb_net.c: In function 'timeout_connect':
cddb_net.c:328:63: error: passing argument 5 of 'getsockopt' from incompatible pointer type [-Wincompatible-pointer-types]
  328 |                 getsockopt(sockfd, SOL_SOCKET, SO_ERROR, &rv, &l);
      |                                                               ^~
      |                                                               |
      |                                                               size_t * {aka long unsigned int *}
In file included from /usr/include/netinet/in.h:23,
                 from ../include/cddb/cddb_conn.h:32,
                 from ../include/cddb/cddb.h:37,
                 from ../include/cddb/cddb_ni.h:58,
                 from cddb_net.c:22:
/usr/include/sys/socket.h:257:46: note: expected 'socklen_t * restrict' {aka 'unsigned int * restrict'} but argument is of type 'size_t *' {aka 'long unsigned int *'}
  257 |                        socklen_t *__restrict __optlen) __THROW;
      |                        ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~



See the meta bug#1220571 for more info.
Comment 1 Martin Schreiner 2024-05-15 14:48:28 UTC 
I cannot reproduce this issue.

I tried building libcddb from Factory with gcc14 and it worked just fine.
The reported link on the bug also shows the operation as having been successful now.

Does this bug still demand our attention, or may we close it?
Thanks.
Comment 2 Michal Jireš 2024-05-16 14:08:10 UTC 
Seems to be already explicitly fixed by https://build.opensuse.org/request/show/1160809

So I will close the issue.
Thanks.