Bug 1221715

Summary: GCC 14: liblogging package fails
Product: [openSUSE] openSUSE Tumbleweed Reporter: Michal Jireš <michal.jires>
Component: DevelopmentAssignee: Thomas Blume <thomas.blume>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: mjambor, thomas.blume
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Michal Jireš 2024-03-19 13:45:44 UTC 
Building liblogging with GCC 14 fails here:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/liblogging/standard/x86_64

Due to:

beepframe.c:170:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  170 | sbFramActualRecvFramCommonBody(sbFramObj* pThis,sbChanObj *pChan)
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
beeplisten.c: In function ‘sbLstnInit’:
beeplisten.c:1055:28: error: implicit declaration of function ‘sbSock_InitUXDOMSOCK’ [-Wimplicit-function-declaration]
 1055 |                 if((iRet = sbSock_InitUXDOMSOCK(&(pThis->pSockUXDOMSOCKListening), pActualSockName, /*SOCK_DGRAM*/ SOCK_STREAM)) != SR_RET_OK)
      |                            ^~~~~~~~~~~~~~~~~~~~




Builds with:

Index: liblogging-1.0.6/rfc3195/src/beepframe.c
===================================================================
--- liblogging-1.0.6.orig/rfc3195/src/beepframe.c
+++ liblogging-1.0.6/rfc3195/src/beepframe.c
@@ -167,6 +167,7 @@ srRetVal sbFramActualRecvFramCommonHdr(s
  *                       The channel object is updated, e.g. with a
  *                       new seqno.
  */
+int
 sbFramActualRecvFramCommonBody(sbFramObj* pThis,sbChanObj *pChan)
 {
 	unsigned iToRcv;
Index: liblogging-1.0.6/rfc3195/src/sockets.h
===================================================================
--- liblogging-1.0.6.orig/rfc3195/src/sockets.h
+++ liblogging-1.0.6/rfc3195/src/sockets.h
@@ -340,4 +340,8 @@ srRetVal sbSockRecvFrom(sbSockObj *pThis
 #	define SOCKET_ERROR -1
 #endif

+#if FEATURE_UNIX_DOMAIN_SOCKETS == 1
+srRetVal sbSock_InitUXDOMSOCK(sbSockObj **ppThis, char *pszSockName, int iSockType);
+#endif
+
 #endif

See the meta bug#1220571 for more info.
Comment 1 Martin Jambor 2024-06-03 14:58:38 UTC 
*** Bug 1225855 has been marked as a duplicate of this bug. ***
Comment 2 Martin Jambor 2024-06-03 15:00:34 UTC 
The corresponding Gentoo bug seems to be:
https://bugs.gentoo.org/926515
Comment 3 Thomas Blume 2024-06-04 06:29:47 UTC 
Hm, not sure why, but the build succeeds despite the error:

https://build.opensuse.org/package/show/openSUSE:Factory/liblogging

However, I have a patched version here:

https://build.opensuse.org/package/show/home:tsaupe:branches:openSUSE:Factory:Staging:Gcc7/liblogging

The mentioned warnings are gone, but there are some more warnings (though apparently not fatal).
Comment 4 OBSbugzilla Bot 2024-06-19 09:15:05 UTC 
This is an autogenerated message for OBS integration:
This bug (1221715) was mentioned in
https://build.opensuse.org/request/show/1181699 Factory:Rings:1-MinimalX / liblogging