Bug 1221904

Summary:	Patch grub2-pass-corret-root-for-nfsroot.patch is using the wrong order of GRUB_FS/GRUB_DEVICE
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Andrei Borzenkov <arvidjaar>
Component:	Bootloader	Assignee:	Michael Chang <mchang>
Status:	NEW ---	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Andrei Borzenkov 2024-03-24 12:41:45 UTC

Patch grub2-pass-corret-root-for-nfsroot.patch results in grub-mkconfig probing for GRUB_DEVICE after the first use in probing for GRUB_FS.

    # Filesystem for the device containing our userland.  Used for stuff like
    # choosing Hurd filesystem module.
    GRUB_FS="`${grub_probe} --device ${GRUB_DEVICE} --target=fs 2> /dev/null || echo unknown`"
    # Device containing our userland.  Typically used for root= parameter.
    GRUB_DEVICE="`${grub_probe} --target=device /`"

It makes probing for GRUB_FS fail which went unnoticed because grub-mkconfig falls back to using `stat -f`. Until at least one user hit weird problem with `stat -f` failing to report `btrfs` filesystem type.

See the details in

https://forums.opensuse.org/t/boot-from-snapshots-missing-from-grub-menu/173485/29

Comment 1 Michael Chang 2024-03-25 01:57:19 UTC

Thanks for pointing this out. And I'm sincerely sorry for the mistake and the trouble it leads to, this shouldn't happen in the first place. :(
I'm going to update grub2 to fix the issue.