Bug 1222168

Summary:	SLES15SP6 : Not able to lock the nvme drive using "the password saved in the kernel SED keyring" of nvme-cli sed commands(nvme/nvme-cli/SED/SL15SP6)
Product:	[openSUSE] PUBLIC SUSE Linux Enterprise Server 15 SP6	Reporter:	LTC BugProxy <bugproxy>
Component:	Kernel	Assignee:	Daniel Wagner <daniel.wagner>
Status:	RESOLVED FIXED	QA Contact:
Severity:	Major
Priority:	P2 - High	CC:	bugproxy, daniel.wagner, gery.schneider, hector.oron, rtsvetkov
Version:	unspecified
Target Milestone:	---
Hardware:	PowerPC-64
OS:	All
See Also:	https://bugzilla.linux.ibm.com/show_bug.cgi?id=205851
Whiteboard:
Found By:	Third Party Developer/Partner	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	supportconfig (External)

Description LTC BugProxy 2024-03-29 18:50:49 UTC

== Comment: #0 - Naresh Bannoth <nbannoth@in.ibm.com> - 2024-03-15 05:01:23 ==
---Problem Description---

we are not able to lock nvme drive using "the password saved in the kernel SED keyring" with nvme-cli sed commands,

logs as below,
----------------

localhost:~ # nvme sed discover /dev/nvme3n1
Locking Features:
	Locking Supported:         Yes
	Locking Feature Enabled:   No
	Locked:                    No
localhost:~ #
localhost:~ # nvme sed initialize /dev/nvme2n1
Password: 
localhost:~ # nvme sed discover /dev/nvme2n1
Locking Features:
	Locking Supported:         Yes
	Locking Feature Enabled:   Yes
	Locked:                    No
localhost:~ # nvme sed lock /dev/nvme2n1
Error: failed locking or unlocking - 1
lock: SED error -  Host Not Authorized
localhost:~ #

localhost:~ # nvme sed discover /dev/nvme2n1
Locking Features:
	Locking Supported:         Yes
	Locking Feature Enabled:   Yes
	Locked:                    No
localhost:~ # 

 
Machine Type = IBM,9105-42A - Rainier 
 
---uname output---
6.4.0-150600.9-default
 
---Debugger---
A debugger is not configured
 
---Steps to Reproduce---
 check the above logs for details steps
 
Contact Information = nbannoth@linux.vnet.ibm.com,maram.srimannarayana.murthy@ibm.com 
 
Userspace tool common name: nvme-cli 
 
The userspace tool has the following bit modes: PPC64le 
 
Oops output:
 no
 
Stack trace output:
 no
 
System Dump Info:
  The system is not configured to capture a system dump.

Userspace rpm: NA 

Userspace tool obtained from project website:  na 
 
*Additional Instructions for nbannoth@linux.vnet.ibm.com,maram.srimannarayana.murthy@ibm.com: 
-Post a private note with access information to the machine that the bug is occuring on. 
-Attach sysctl -a output output to the bug.
-Attach ltrace and strace of userspace application.




== Comment: #3 - Luciano Chavez <chavez@us.ibm.com> - 2024-03-19 14:35:35 ==
Other that some medium and I/O errors, there are any other log entries of interest related to nvme devices in the logs

2024-03-15T05:14:52.562470-04:00 localhost kernel: [59045.841581][T28241] ldm_validate_partition_table(): Disk read failed.
2024-03-15T05:14:52.572420-04:00 localhost kernel: [59045.844572][T28241]  nvme3n1: unable to read partition table
2024-03-15T05:15:20.296409-04:00 localhost kernel: [59073.576658][    C9] nvme_log_error: 70 callbacks suppressed
2024-03-15T05:15:20.296423-04:00 localhost kernel: [59073.576663][    C9] nvme2c0n1: I/O Cmd(0x2) @ LBA 0, 2 blocks, I/O Error (sct 0x2 / sc 0x86
) DNR
2024-03-15T05:15:20.296424-04:00 localhost kernel: [59073.576677][    C9] blk_print_req_error: 70 callbacks suppressed
2024-03-15T05:15:20.296425-04:00 localhost kernel: [59073.576678][    C9] critical medium error, dev nvme2c0n1, sector 0 op 0x0:(READ) flags 0x20
00000 phys_seg 1 prio class 2
2024-03-15T05:15:20.296429-04:00 localhost kernel: [59073.576684][    C9] buffer_io_error: 70 callbacks suppressed
2024-03-15T05:15:20.296430-04:00 localhost kernel: [59073.576685][    C9] Buffer I/O error on dev nvme2n1, logical block 0, async page read




== Comment: #9 - Greg Joyce <gjoyce@ibm.com> - 2024-03-28 10:09:14 ==
The initialize command was not saving the password in the kernel keyring. This is fixed by https://github.com/linux-nvme/nvme-cli/pull/2273

As a workaround until the fix is available, the password can be saved after initialize by:
   nvme sed password /dev/nvme2n1

Comment 1 LTC BugProxy 2024-03-29 18:51:00 UTC

Created attachment 873942 [details]
supportconfig (External)

Comment 2 Géry Schneider 2024-03-29 19:41:40 UTC

Hello SUSE,
This bug has been opened while verifying the Feature requests:
- Jira Epic IBM-1212 Enable SED-OPAL support (LTC Bug 201158)
- Jira Epic IBM-1322 addition of sed commands in NVMe library for ppc64le (LTC Bug 205095)
and it has a workaround.
Thank you for your support.

Comment 3 Daniel Wagner 2024-04-04 11:26:37 UTC

I've queued up the package update with the requested fix.

Comment 5 LTC BugProxy 2024-04-16 13:51:47 UTC

------- Comment From nbannoth@in.ibm.com 2024-04-15 08:09 EDT-------
Verified this issue with latest RC1 Build and it is working fine.

Logs as below,
-----------------

localhost:~ # uname -a
Linux localhost 6.4.0-150600.13-default #1 SMP Fri Apr  5 02:31:02 UTC 2024 (80962db) ppc64le ppc64le ppc64le GNU/Linux
localhost:~ #
localhost:~ # nvme version
nvme version 2.8 (git 2.8+12.g34d799c)
libnvme version 1.8 (git 1.8+8.g8c9685f)
localhost:~ #
localhost:~ # rpm -qa | grep -i nvme-cli
nvme-cli-2.8+12.g34d799c-150600.1.1.ppc64le
nvme-cli-bash-completion-2.8+12.g34d799c-150600.1.1.noarch
localhost:~ #
localhost:~ # cat /etc/os-release
NAME="SLES"
VERSION="15-SP6"
VERSION_ID="15.6"
PRETTY_NAME="SUSE Linux Enterprise Server 15 SP6"
ID="sles"
ID_LIKE="suse"
ANSI_COLOR="0;32"
CPE_NAME="cpe:/o:suse:sles:15:sp6"
DOCUMENTATION_URL="https://documentation.suse.com/"
localhost:~ #
localhost:~ # nvme sed discover /dev/nvme
nvme-fabrics  nvme1         nvme2         nvme3
nvme0         nvme1n1       nvme2n1
localhost:~ # nvme sed discover /dev/nvme
nvme-fabrics  nvme1         nvme2         nvme3
nvme0         nvme1n1       nvme2n1
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   No
Locked:                    No
localhost:~ #
localhost:~ # nvme sed initialize /dev/nvme1n1
Password:
localhost:~ #
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    No
localhost:~ #
localhost:~ # nvme sed lock /dev/nvme1n1
localhost:~ #
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    Yes
localhost:~ #
localhost:~ # nvme sed lock /dev/nvme1n1
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    Yes
localhost:~ #
localhost:~ # nvme sed unlock /dev/nvme1n1
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    No
localhost:~ #
localhost:~ # nvme sed lock /dev/nvme1n1
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    Yes
localhost:~ # nvme sed unlock /dev/nvme1n1
localhost:~ # nvme sed discover /dev/nvme1n1
Locking Features:
Locking Supported:         Yes
Locking Feature Enabled:   Yes
Locked:                    No
localhost:~ #

Regards
Naresh

------- Comment From gery.schneider@fr.ibm.com 2024-04-16 09:45 EDT-------
(In reply to comment #25)
> Verified this issue with latest RC1 Build and it is working fine.
[...]

Thank you Naresh for this verification, and thank you all for your support.
I am closing this bug.

Comment 6 Daniel Wagner 2024-04-16 15:54:36 UTC

Fixed shipped and verified.