Bug 1223069

OS: Tumbleweed 20240416
earlyoom version: 1.8-1.1

After updating today I noticed that earlyoom crashes:

> bal. 18 10:40:50 earlyoom[13343]: earlyoom 1.8
> bal. 18 10:40:50 earlyoom[13343]: Notifying through D-Bus
> bal. 18 10:40:50 earlyoom[13343]: Preferring to kill process names that match regex '(^|/)(java|Isolated Web Co|Web Content|WebExtensions|firefox|chrome|opera|falkon|ffmpeg|vlc|mpv|akregator|thumbnail.so)$'
> bal. 18 10:40:50 earlyoom[13343]: Will avoid killing process names that match regex '(^|/)(systemd|Xorg|X|Xwayland|xdm|sddm|kdm|gdm|lightdm|plasmashell|kwin_wayland|kwin_x11|ssh|yast|yast2|y2controlcenter|zypper|rpm|dnf)$'
> bal. 18 10:40:50 systemd[1]: Started Process Core Dump (PID 13344/UID 0).
> bal. 18 10:40:50 systemd-coredump[13345]: [🡕] Process 13343 (earlyoom) of user 61876 dumped core.
>                                         
>                                           Stack trace of thread 13343:
>                                           #0  0x00007f260bb07b5b setpriority (libc.so.6 + 0x107b5b)
>                                           #1  0x000055845a69a161 n/a (earlyoom + 0x3161)
>                                           #2  0x00007f260ba2a1f0 __libc_start_call_main (libc.so.6 + 0x2a1f0)
>                                           #3  0x00007f260ba2a2b9 __libc_start_main@@GLIBC_2.34 (libc.so.6 + 0x2a2b9)
>                                           #4  0x000055845a69a3b5 n/a (earlyoom + 0x33b5)
>                                           ELF object binary architecture: AMD x86-64
> bal. 18 10:40:50 systemd[1]: earlyoom.service: Main process exited, code=dumped, status=31/SYS
> bal. 18 10:40:50 systemd[1]: earlyoom.service: Failed with result 'core-dump'.


From the stack trace it has something to do with the setpriority function, earlyoom has a flag -p to increase it's priority, from the man page:

>    -p
>        Increase earlyoom’s priority: set niceness of earlyoom to -20 and oom_score_adj to -100.
>
>        When earlyoom is run through its default systemd service, the -p switch doesn’t work.  To achieve the same effect, enter the following three lines into sudo systemctl edit earlyoom:
>
>               [Service]
>               OOMScoreAdjust=-100
>               Nice=-20

My config in /etc/sysconfig/earlyoom had -p:

> EARLYOOM_ARGS="-r 0 -M 524288 -s 10 -n -p --avoid '(^|/)(systemd|Xorg|X|Xwayland|xdm|sddm|kdm|gdm|lightdm|plasmashell|kwin_wayland|kwin_x11|ssh|yast|yast2|y2controlcenter|zypper|rpm|dnf)$' --prefer '(^|/)(java|Isolated\ Web\ Co|Web\ Content|WebExtensions|firefox|chrome|opera|falkon|ffmpeg|vlc|mpv|akregator|thumbnail.so)$'"

After removing the -p flag the service starts and since the systemd service config already contains the niceness and OOM score adjustments I guess this flag isn't really needed.