Bug 1223504

Summary:	transactional_update cannot deal with new table look of snapper
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Arvin Schnell <aschnell>
Component:	Basesystem	Assignee:	Santiago Zarate <santiago.zarate>
Status:	REOPENED ---	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	ana.guerrero, aschnell, mkravec, santiago.zarate
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Development	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description Arvin Schnell 2024-04-29 10:02:52 UTC

See https://build.opensuse.org/request/show/1169010.

snapper uses unicode symbols for the table lines now. The code
in transactional_update cannot deal with that:

  https://github.com/openSUSE/transactional-update/blob/master/sbin/transactional-update.in#L1383

transactional_update should use the CSV or JSON output of snapper
instead. CSV is partly used already:

  https://github.com/openSUSE/transactional-update/blob/master/systemd/prepare-nextroot-for-softreboot#L14

Comment 1 Ignaz Forster 2024-04-30 13:14:49 UTC

Fixed in transactional-update 4.6.7: https://build.opensuse.org/request/show/1170997

Comment 2 Ana Guerrero 2024-05-03 11:52:05 UTC

I'm afraid there is still some issue going on, see the failure in the transactional_update test:

https://openqa.opensuse.org/tests/4159669#step/transactional_update/196



transactional-update 4.6.7 started
Options: -n rollback 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│
Separate /var detected.
Rollback to snapshot 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│...
/sbin/transactional-update: line 1293: [: 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│: integer expression expected
2024-05-03 10:43:26 tukit 4.6.7 started
2024-05-03 10:43:26 Options: rollback 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│ 
Invalid snapshot '8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│'.
ERROR: `snapper rollback 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│` returned with error code 1.
ERROR: Rollback to snapshot 8│single││FriMay310:40:462024│root│12.07MiB│number│SnapshotUpdateof#7│ failed!
transactional-update finished
HWQhg-1-


And snapper_create (IIRC this is the original issue)

https://openqa.opensuse.org/tests/4159674#step/snapper_create/25

Comment 3 Arvin Schnell 2024-05-03 13:28:13 UTC

That looks more like a problem of openQA to me (I have already reported
one, see bug #1223840).

Comment 4 Ignaz Forster 2024-05-06 05:06:58 UTC

Yes, these are the openQA tests themselves failing. Assigning to Martin.

Comment 5 OBSbugzilla Bot 2024-05-07 15:05:01 UTC

This is an autogenerated message for OBS integration:
This bug (1223504) was mentioned in
https://build.opensuse.org/request/show/1172470 Factory / transactional-update

Comment 6 Martin Kravec 2024-05-15 06:20:45 UTC

Assigned to Dominik since he wrote snapper parsing code.

See https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/19231 for possible fix.