Bug 1223909

Summary:	Package vlc fails to build with gcc 14 because of assignments from incompatible pointer types
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Jambor <mjambor>
Component:	Other	Assignee:	Dominique Leuenberger <dimstar>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None	CC:	dimstar
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1220571

Description Martin Jambor 2024-05-05 17:22:59 UTC

Vlc fails when built with GCC 14 because of use incompatible pointer
types, which used to be warnings in previous versions of GCC but are
errors by default in GCC 14:  

https://build.opensuse.org/package/live_build_log/home:rguenther:plgrnd/vlc/openSUSE_Factory/x86_64

The bug seems to have been reported upstream as
  https://code.videolan.org/videolan/vlc/-/issues/28441
and to Gentoo as https://bugs.gentoo.org/919068.  but there is also
yet unresolved) Gentoo issue https://bugs.gentoo.org/919296 so the
particular error might not be the only one.

For more information on porting to gcc 14, see
https://gcc.gnu.org/gcc-14/porting_to.html

Comment 1 Dominique Leuenberger 2024-05-14 15:15:29 UTC

Added upstream MR 4645 onto the package.


This contains:

Subject: [PATCH 1/5] input: fix incompatible-pointer-types assignment
Subject: [PATCH 2/5] yadif: fix variable type
Subject: [PATCH 3/5] swscale: avoid invalid pointer conversion
Subject: [PATCH 4/5] dynamicoverlay: fix variable shadowing
Subject: [PATCH 5/5] dynamicoverlay: fix memory corruption

Build is still to passing on GCC14 yet, but we're getting closer at least

Comment 2 Dominique Leuenberger 2024-05-22 13:13:13 UTC

backported one more commit:

https://code.videolan.org/videolan/vlc/-/merge_requests/4665/diffs?commit_id=770789f265761fc7ab2de69ca105fec4ad93d9e2
=>
https://build.opensuse.org/request/show/1175850

Wit this, vLC now builds using GCC14

Comment 3 OBSbugzilla Bot 2024-06-13 11:25:04 UTC

This is an autogenerated message for OBS integration:
This bug (1223909) was mentioned in
https://build.opensuse.org/request/show/1180387 Backports:SLE-15-SP5 / vlc
https://build.opensuse.org/request/show/1180388 Backports:SLE-15-SP6 / vlc
https://build.opensuse.org/request/show/1180389 Backports:SLE-15-SP4 / vlc

Comment 4 OBSbugzilla Bot 2024-06-13 14:55:07 UTC

This is an autogenerated message for OBS integration:
This bug (1223909) was mentioned in
https://build.opensuse.org/request/show/1180704 Backports:SLE-15-SP6 / vlc
https://build.opensuse.org/request/show/1180705 Backports:SLE-15-SP5 / vlc
https://build.opensuse.org/request/show/1180706 Backports:SLE-15-SP4 / vlc

Comment 5 OBSbugzilla Bot 2024-06-14 13:55:03 UTC

This is an autogenerated message for OBS integration:
This bug (1223909) was mentioned in
https://build.opensuse.org/request/show/1180919 Backports:SLE-15-SP5 / vlc

Comment 6 Marcus Meissner 2024-06-17 22:04:52 UTC

openSUSE-RU-2024:0165-1: An update that has two recommended fixes can now be installed.

Category: recommended (moderate)
Bug References: 1219494,1223909
CVE References: 
JIRA References: 
Sources used:
openSUSE Backports SLE-15-SP5 (src):    vlc-3.0.21-bp155.2.6.1