Bug 1225777

Summary:	Package hplip does not build with gcc14 because of new errors
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Jambor <mjambor>
Component:	Printing	Assignee:	Johannes Meixner <jsmeix>
Status:	NEW ---	QA Contact:	Johannes Meixner <jsmeix>
Severity:	Normal
Priority:	P5 - None	CC:	martin.wilck
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1220571

Description Martin Jambor 2024-05-31 20:15:00 UTC

GCC 14 newly by default treats as errors a number of situations which
before were only warnings.  For more information see
https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571.

Because of this, package hplip fails to compile.  This can be seen online
at:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/hplip/standard/x86_64

It can be reproduced locally with command: osc build --clean
--alternative-project home:rguenther:nextgcc

Fedora dealt with these issues as described at
https://gitlab.com/fweimer-rh/fedora-modernc/-/blob/main/pkg/h/hplip.md?ref_type=heads
We seem to need at least https://bugs.launchpad.net/hplip/+bug/1997875
and https://bugs.launchpad.net/hplip/+bug/2048780

The error (that halts the build) is:

[   31s] prnt/hpps/pserror.c: In function ‘message’:
[   31s] prnt/hpps/pserror.c:27:10: error: type defaults to ‘int’ in declaration of ‘column’ [-Wimplicit-int]
[   31s]    27 |   static column = 0 ;           /* current screen column for message wrap */
[   31s]       |          ^~~~~~

Comment 1 Martin Jambor 2024-07-15 15:33:52 UTC

I have used (the relevant) patches were taken from
https://src.fedoraproject.org/rpms/hplip/c/bbb19dff5e32c47720b7523412dd7a59112a19a3?branch=rawhide
and
https://src.fedoraproject.org/rpms/hplip/c/d726b77698ed806fb84e482fb40202548095fbe1?branch=rawhide
and created https://build.opensuse.org/request/show/1187590

Comment 2 Martin Wilck 2024-07-15 19:09:06 UTC

upstream: <https://bugs.launchpad.net/hplip/+bug/1997875

Comment 3 Martin Jambor 2024-07-16 08:03:07 UTC

(In reply to Martin Wilck from comment #2)
> upstream: <https://bugs.launchpad.net/hplip/+bug/1997875

Just to be clear, this launchpad bug corresponds to the patches in the first link referenced in comment #1 - from the same author.