Bug 1225800

Summary:	Package libesmtp does not build with gcc14 because of new errors
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Jambor <mjambor>
Component:	Network	Assignee:	Paolo Stivanin <pstivanin>
Status:	NEW ---	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1220571

Description Martin Jambor 2024-06-02 21:12:08 UTC

GCC 14 newly by default treats as errors a number of situations which
before were only warnings.  For more information see
https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571.

Because of this, package libesmtp fails to compile.  This can be seen online
at:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/libesmtp/standard/x86_64

It can be reproduced locally with command: osc build --clean
--alternative-project home:rguenther:nextgcc

Notes from fedora-modernc project however suggest that "removing
autotools" is necessary: https://gitlab.com/fweimer-rh/fedora-modernc/-/blob/main/pkg/l/libesmtp.md?ref_type=heads


The (first) error (that halts the build) is:

[   24s] ../smtp-api.c: In function ‘smtp_version’:
[   24s] ../smtp-api.c:1183:7: error: implicit declaration of function ‘strlcpy’; did you mean ‘strncpy’? [-Wimplicit-function-declaration]
[   24s]  1183 |   if (strlcpy (buf, v, len) > len)
[   24s]       |       ^~~~~~~
[   24s]       |       strncpy

Comment 1 Martin Jambor 2024-07-10 14:40:56 UTC

Sorry, I was confused, the RedHat patch directly changes an autotools
generated file and the reference they have given is to a commit that
removes autotools from the project.

But the Factory version no longer has auto-tools, the issue is merely
a missing feature macro definition.

Comment 2 Martin Jambor 2024-07-10 14:47:49 UTC

I have created https://build.opensuse.org/request/show/1186626