Bug 1225904

Summary: Package openssh does not build with gcc14 because of new errors
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Jambor <mjambor>
Component: NetworkAssignee: Antonio Larrosa <alarrosa>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: alarrosa, hpj
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Martin Jambor 2024-06-04 08:44:54 UTC
GCC 14 newly by default treats as errors a number of situations which
before were only warnings.  For more information see
https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571.

Because of this, package openssh fails to compile.  This can be seen online
at:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/openssh/standard/x86_64

It can be reproduced locally with command: osc build --clean
--alternative-project home:rguenther:nextgcc

We most likely need patches listed at:
https://gitlab.com/fweimer-rh/fedora-modernc/-/blob/main/pkg/o/openssh.md?ref_type=heads


The (first) error (that halts the build) is:

[   48s] ldapconf.c: In function ‘process_config_line’:
[   48s] ldapconf.c:250:25: error: implicit declaration of function ‘strtol’; did you mean ‘strtok’? [-Wimplicit-function-declaration]
[   48s]   250 |                 value = strtol(arg, &endofnumber, 0);
[   48s]       |                         ^~~~~~
[   48s]       |                         strtok
Comment 1 Antonio Larrosa 2024-06-10 09:57:02 UTC
I submitted https://build.opensuse.org/request/show/1179619 to fix the issue when running the command you mentioned (thanks for that, the command made it very easy to reproduce and fix this) and Dirk already approved and forwarded it to Factory
Comment 2 Antonio Larrosa 2024-07-01 15:16:50 UTC
Fixed as mentioned in previous comment
Comment 8 Maintenance Automation 2024-07-10 16:30:04 UTC
SUSE-SU-2024:2393-1: An update that solves two vulnerabilities and has three security fixes can now be installed.

Category: security (moderate)
Bug References: 1218215, 1224392, 1225904, 1227318, 1227350
CVE References: CVE-2023-51385, CVE-2024-39894
Maintenance Incident: [SUSE:Maintenance:34681](https://smelt.suse.de/incident/34681/)
Sources used:
openSUSE Leap 15.6 (src):
 openssh-askpass-gnome-9.6p1-150600.6.6.1, openssh-9.6p1-150600.6.6.1
Basesystem Module 15-SP6 (src):
 openssh-9.6p1-150600.6.6.1
Desktop Applications Module 15-SP6 (src):
 openssh-askpass-gnome-9.6p1-150600.6.6.1

NOTE: This line indicates an update has been released for the listed product(s). At times this might be only a partial fix. If you have questions please reach out to maintenance coordination.