Bug 1225909

Summary:	Package perl-Tk does not build with gcc14 because of new errors
Product:	[openSUSE] openSUSE Tumbleweed	Reporter:	Martin Jambor <mjambor>
Component:	Development	Assignee:	Petr Gajdos <pgajdos>
Status:	REOPENED ---	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P4 - Low	CC:	opensuse, pgajdos
Version:	Current
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	---	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Bug Depends on:
Bug Blocks:	1220571
Attachments:	Possible fix

Description Martin Jambor 2024-06-04 09:51:33 UTC

GCC 14 newly by default treats as errors a number of situations which
before were only warnings.  For more information see
https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571.

Because of this, package perl-Tk fails to compile.  This can be seen online
at:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/perl-Tk/standard/x86_64

It can be reproduced locally with command: osc build --clean
--alternative-project home:rguenther:nextgcc

Hopefully relevant upstream pull request is:
https://github.com/eserte/perl-tk/pull/91

Fedora apparently fixed this with
https://src.fedoraproject.org/rpms/perl-Tk/c/8c1ed1e6b9efa3e28e9858ffeb73b7bacad2ef8a?branch=rawhide

Comment 1 Martin Jambor 2024-06-19 13:59:20 UTC

Created attachment 875581 [details]
Possible fix

We need more than what is in the pull request referenced in the bug summary.  I made the package build with this patch.

Comment 2 Martin Jambor 2024-07-03 20:33:10 UTC

I have created https://build.opensuse.org/request/show/1185237 which
contains just the configury bits of the patch from comment #1 and then
added -fpermissive to the optflags in the spec file.  This is the
safest we can do without diverging from the upstream too much, which is
where the issues will hopefully be solved when GCC 14 is more widespread.

I plan to keep this bug opened so that the need for -fpermissive can be
reviewed in the future.

Comment 3 OBSbugzilla Bot 2024-07-07 20:25:02 UTC

This is an autogenerated message for OBS integration:
This bug (1225909) was mentioned in
https://build.opensuse.org/request/show/1186036 Factory / perl-Tk

Comment 4 Petr Gajdos 2024-07-08 11:03:04 UTC

(In reply to OBSbugzilla Bot from comment #3)
> This is an autogenerated message for OBS integration:
> This bug (1225909) was mentioned in
> https://build.opensuse.org/request/show/1186036 Factory / perl-Tk

This is revoked trough the comment of Dirk Stoecker (cpan.yml is not used).

Comment 5 Petr Gajdos 2024-07-08 11:03:59 UTC

This is already reported upstream:

https://github.com/eserte/perl-tk/issues/105

Feel free to add your patch there, if you want.

Comment 6 Petr Gajdos 2024-07-08 11:09:43 UTC

Also here:
https://github.com/eserte/perl-tk/issues/98

Comment 7 Martin Jambor 2024-07-08 11:29:22 UTC

And there is also the https://github.com/eserte/perl-tk/pull/91 

Hopefully people will start to care with GCC 14 out now and being used in Fedora  and hopefully by us soon too.

Thanks for all the help.

Comment 8 Petr Gajdos 2024-07-08 13:00:37 UTC

Submit into devel project:
https://build.opensuse.org/request/show/1186169

Comment 9 Petr Gajdos 2024-07-10 08:04:10 UTC

The request is accepted.

Comment 10 Martin Jambor 2024-07-10 10:27:51 UTC

I'm reopening and assigning to myself so that in a year or three I can have a look whether fpermissive is still necessary.  I hope that is OK.

Comment 11 Petr Gajdos 2024-07-12 08:16:12 UTC

Reassigning back to me.