Bug 1225951

Summary: Package vinagre does not build with gcc14 because of new errors
Product: [openSUSE] openSUSE Tumbleweed Reporter: Martin Jambor <mjambor>
Component: NetworkAssignee: Martin Jambor <mjambor>
Status: NEW --- QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 1220571    

Description Martin Jambor 2024-06-04 15:38:49 UTC 
GCC 14 newly by default treats as errors a number of situations which
before were only warnings.  For more information see
https://gcc.gnu.org/gcc-14/porting_to.html and meta bug #1220571.

Because of this, package vinagre fails to compile.  This can be seen online
at:
https://build.opensuse.org/package/live_build_log/openSUSE:Factory:Staging:Gcc7/vinagre/standard/x86_64

It can be reproduced locally with command: osc build --clean
--alternative-project home:rguenther:nextgcc

We probably need the patch attached to https://bugzilla.redhat.com/show_bug.cgi?id=2179869


The (first) error (that halts the build) is:

[   23s] vinagre/vinagre-dirs.c: In function ‘vinagre_dirs_get_package_data_file’:
[   23s] vinagre/vinagre-dirs.c:121:25: error: assignment to ‘gchar **’ {aka ‘char **’} from incompatible pointer type ‘const gchar * const*’ {aka ‘const char * const*’} [-Wincompatible-pointer-types]
[   23s]   121 |         _tmp1_ = _tmp0_ = g_get_system_data_dirs ();
Comment 1 Martin Jambor 2024-06-19 15:57:29 UTC 
The issue described at the bottom of the bug summary is in vinagre-dirs.c which is generated by valac, so until vala is fixed, we need to resort to -fpermissive.  After vala is fixed and the file is regenerated, we can potentioally also use the patch from Fedora to clean up any remaining issues.
Comment 2 Martin Jambor 2024-06-20 15:14:19 UTC 
I have filed https://build.opensuse.org/request/show/1181980 to add -fpermissive for now.
Comment 3 OBSbugzilla Bot 2024-06-20 17:45:02 UTC 
This is an autogenerated message for OBS integration:
This bug (1225951) was mentioned in
https://build.opensuse.org/request/show/1182000 Factory / vinagre
Comment 4 Chenzi Cao 2024-07-01 08:04:49 UTC 
Hi Martin, you already submitted request for this bug report, so I assign it to you . Please feel free to reassign if I get wrong, thanks.