Bug 1226446

Summary: AUDIT-WHITELIST: backintime: DBUS service helper location change
Product: [openSUSE] openSUSE Tumbleweed Reporter: Tejas Guruswamy <masterpatricko>
Component: SecurityAssignee: Matthias Gerstner <matthias.gerstner>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: matthias.gerstner, security-team
Version: Current   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: --- Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Tejas Guruswamy 2024-06-17 17:47:18 UTC
The backintime service DBUS helper -- previously reviewed in boo#1007723 -- has moved location from /etc/dbus-1/system.d/net.launchpad.backintime.serviceHelper.conf to /usr/share .

Update is ready to submit to Factory (https://build.opensuse.org/request/show/1181254)

Does this need a re-review or just a rename?

Thanks!
Comment 1 Tejas Guruswamy 2024-06-17 17:52:05 UTC
Missed the OBS devel project link: obs://Archiving:Backup/backintime https://build.opensuse.org/package/show/Archiving:Backup/backintime

Thanks
Comment 2 Matthias Gerstner 2024-06-18 07:33:15 UTC
Thank you for creating the AUDIT bug. Given the occasion we will have a look
into the current code if anything major changed, but otherwise it will mostly
be about adjusting to the new paths.

We currently have a bit of a backlog with reviews, thus it can take a couple
of days before we can start yours.
Comment 3 Matthias Gerstner 2024-06-18 16:35:20 UTC
Since this is a rather small review I will take it right away after all.

I noticed the patch "backintime-polkit_priv_downgrade.patch" in the backintime
package. I suggested it myself in the original review bug all these years ago.
Actually the patch is unnecessary, though. The polkit-default-privs settings
will override the backintime policy anyway, this is what they are here for.

So I suggest you drop that patch, refering to this comment here in this bug.
Comment 4 Matthias Gerstner 2024-06-18 16:50:04 UTC
A look into the upstream repository shows that nothing really changed in the
service helper since 2017. We can go ahead with the whitelisting.
Comment 5 Tejas Guruswamy 2024-06-26 02:22:00 UTC
Thanks! Also the redundant patch backintime-polkit_priv_downgrade.patch is now removed.
Comment 6 Matthias Gerstner 2024-07-05 12:40:06 UTC
thanks for dropping the patch, the whitelisting is now also in Factory,
closing this bug as fixed.