Bug 1226725

Summary: [Build 20240617] openQA test fails in bootloader_s390 - color change in Installer UI
Product: [openSUSE] openSUSE Tumbleweed Reporter: Matthias Griessmeier <mgriessmeier>
Component: X.OrgAssignee: Gfx Bugs <gfx-bugs>
Status: RESOLVED FIXED QA Contact: Gfx Bugs <gfx-bugs>
Severity: Major    
Priority: P3 - Medium CC: ada.lovelace, ihno, marcela.maslanova, mgriessmeier
Version: Current   
Target Milestone: ---   
Hardware: S/390-64   
OS: Other   
URL: https://openqa.opensuse.org/tests/4288524/modules/bootloader_s390/steps/59
Whiteboard:
Found By: openQA Services Priority:
Business Priority: Blocker: Yes
Marketing QA Status: --- IT Deployment: ---
Attachments: [20240614] - last good
[20240617] - first bad

Description Matthias Griessmeier 2024-06-21 10:22:59 UTC
## Observation


The Color of the YaST Installer Welcome screen changed from Build 20240614 to 20240617 on s390x

From the changelog, the most promising candidates of causing this:
>  Mesa (24.0.9 -> 24.1.0)
>  Mesa-drivers (24.0.9 -> 24.1.0)

see attached screenshots for reference


openQA test in scenario opensuse-Tumbleweed-DVD-s390x-textmode-server@s390x-zVM-vswitch-l2 fails in
[bootloader_s390](https://openqa.opensuse.org/tests/4288524/modules/bootloader_s390/steps/59)

## Test suite description
The base test suite is used for job templates defined in YAML documents. It has no settings of its own.


## Reproducible

Fails since (at least) Build [20240606](https://openqa.opensuse.org/tests/4255925)


## Expected result

Last good: [20240531](https://openqa.opensuse.org/tests/4243619) (or more recent)


## Further details

Always latest result in this scenario: [latest](https://openqa.opensuse.org/tests/latest?arch=s390x&distri=opensuse&flavor=DVD&machine=s390x-zVM-vswitch-l2&test=textmode-server&version=Tumbleweed)
Comment 1 Matthias Griessmeier 2024-06-21 10:23:36 UTC
Created attachment 875635 [details]
[20240614] - last good
Comment 2 Matthias Griessmeier 2024-06-21 10:23:55 UTC
Created attachment 875636 [details]
[20240617] - first bad
Comment 3 Stefan Dirsch 2024-06-21 10:41:03 UTC
Hmm. That could be a duplicate of boo#1226462. I will build test packages with LTO disabled also on s390x in

https://build.opensuse.org/package/show/home:sndirsch:branches:X11:XOrg/Mesa

Could you please test with these? Or tell me how to ssh to such a system so I can add this repository and replace the Mesa packages?
Comment 4 Stefan Dirsch 2024-06-21 10:43:00 UTC
Latest RPM changelog

Fri Jun 21 10:36:34 UTC 2024 - Stefan Dirsch <sndirsch@suse.com>

- disable LTO also on s390x for testing purposes (bsc#1226725)
Comment 5 Matthias Griessmeier 2024-06-24 14:41:48 UTC
(In reply to Stefan Dirsch from comment #3)

> Or tell me how to ssh to such a system so
> I can add this repository and replace the Mesa packages?

provided via DM
Comment 6 Stefan Dirsch 2024-06-25 09:24:16 UTC
Ok. I see a regression for s390x on Xvnc between 240.9 and Mesa 24.1.1

Mesa 24.1.1

$ glxinfo -B
name of display: :0
Mesa 24.1.1 implementation error: Unexpected format PIPE_FORMAT_X8B8G8R8_SRGB in st_new_renderbuffer_fb
Please report at https://gitlab.freedesktop.org/mesa/mesa/-/issues
Error: unable to load GL functions

Mesa 24.0.9

$ glxinfo -B
name of display: :0
display: :0  screen: 0
direct rendering: Yes
Extended renderer info (GLX_MESA_query_renderer):
    Vendor: Mesa (0xffffffff)
    Device: llvmpipe (LLVM 18.1.6, 128 bits) (0xffffffff)
    Version: 24.0.9
    Accelerated: no
    Video memory: 1747MB
    Unified memory: yes
    Preferred profile: core (0x1)
    Max core profile version: 4.5
    Max compat profile version: 4.5
    Max GLES1 profile version: 1.1
    Max GLES[23] profile version: 3.2
Memory info (GL_ATI_meminfo):
    VBO free memory - total: 4292874677 MB, largest block: 4292874677 MB
    VBO free aux. memory - total: 1510 MB, largest block: 1510 MB
    Texture free memory - total: 4292874677 MB, largest block: 4292874677 MB
    Texture free aux. memory - total: 1510 MB, largest block: 1510 MB
    Renderbuffer free memory - total: 4292874677 MB, largest block: 4292874677 MB
    Renderbuffer free aux. memory - total: 1510 MB, largest block: 1510 MB
Memory info (GL_NVX_gpu_memory_info):
    Dedicated video memory: 0 MB
    Total available memory: 1748 MB
    Currently available dedicated video memory: 4292874677 MB
OpenGL vendor string: Mesa
OpenGL renderer string: llvmpipe (LLVM 18.1.6, 128 bits)
OpenGL core profile version string: 4.5 (Core Profile) Mesa 24.0.9
OpenGL core profile shading language version string: 4.50
OpenGL core profile context flags: (none)
OpenGL core profile profile mask: core profile

OpenGL version string: 4.5 (Compatibility Profile) Mesa 24.0.9
OpenGL shading language version string: 4.50
OpenGL context flags: (none)
OpenGL profile mask: compatibility profile

OpenGL ES profile version string: OpenGL ES 3.2 Mesa 24.0.9
OpenGL ES profile shading language version string: OpenGL ES GLSL ES 3.20
Comment 7 Stefan Dirsch 2024-06-25 09:25:02 UTC
I'm not sure how this is related to the wrong color shown though.
Comment 8 Stefan Dirsch 2024-06-25 09:56:40 UTC
Already reported upstream.

https://gitlab.freedesktop.org/mesa/mesa/-/issues/11360

and supposedly fixed in fix-format-defs branch of Daniel Stone's Mesa fork.

https://gitlab.freedesktop.org/daniels/mesa/-/tree/fix-format-defs?ref_type=heads
https://gitlab.freedesktop.org/daniels/mesa/-/commit/79ca6e3a329dbfc3bc68df37b8f3ea7156e41aae

If this also fixes the wrong color during installation is completely unknown.
Comment 9 Stefan Dirsch 2024-06-25 11:47:45 UTC
(In reply to Stefan Dirsch from comment #8)
> Already reported upstream.
> 
> https://gitlab.freedesktop.org/mesa/mesa/-/issues/11360
> 
> and supposedly fixed in fix-format-defs branch of Daniel Stone's Mesa fork.
> 
> https://gitlab.freedesktop.org/daniels/mesa/-/tree/fix-format-
> defs?ref_type=heads
> https://gitlab.freedesktop.org/daniels/mesa/-/commit/
> 79ca6e3a329dbfc3bc68df37b8f3ea7156e41aae
> 
> If this also fixes the wrong color during installation is completely unknown.

I can confirm that this patch fixes the issue of comment#6.
Comment 10 Stefan Dirsch 2024-06-25 11:48:32 UTC
The original issue should be retested with updated Mesa packages. Verify that RPM changelog includes:

Tue Jun 25 11:14:15 UTC 2024 - Stefan Dirsch <sndirsch@suse.com>

- u_dri-Fix-BGR-format-exclusion.patch
  * fixes glxinfo/eglxinfo on s390x (boo#1226725, comment#6)
Comment 11 Stefan Dirsch 2024-06-25 11:50:41 UTC
(In reply to Stefan Dirsch from comment #10)
> The original issue should be retested with updated Mesa packages. Verify
> that RPM changelog includes:
> 
> Tue Jun 25 11:14:15 UTC 2024 - Stefan Dirsch <sndirsch@suse.com>
> 
> - u_dri-Fix-BGR-format-exclusion.patch
>   * fixes glxinfo/eglxinfo on s390x (boo#1226725, comment#6)

https://build.opensuse.org/request/show/1183150
Comment 12 Stefan Dirsch 2024-06-25 12:01:21 UTC
Please test with next TW build containing this fix.
Comment 13 Matthias Griessmeier 2024-06-26 08:37:31 UTC
(In reply to Stefan Dirsch from comment #12)
> Please test with next TW build containing this fix.

with the updated package, the color distortion can now also be seen on x86_64:
https://openqa.opensuse.org/tests/4299576#step/online_repos/2

according to DimStar - this staging build contains the supposed fix
https://build.opensuse.org/request/show/1183150
Comment 14 OBSbugzilla Bot 2024-06-26 09:25:03 UTC
This is an autogenerated message for OBS integration:
This bug (1226725) was mentioned in
https://build.opensuse.org/request/show/1183326 Factory / Mesa
Comment 15 Stefan Dirsch 2024-06-26 09:40:56 UTC
(In reply to OBSbugzilla Bot from comment #14)
> This is an autogenerated message for OBS integration:
> This bug (1226725) was mentioned in
> https://build.opensuse.org/request/show/1183326 Factory / Mesa

Next try. If that doesn't help I will limit these new patches to s390x for the time being until this thing gets fixed upstream. Better wrong colors than no GL at all.
Comment 16 Stefan Dirsch 2024-06-27 11:12:55 UTC
(In reply to Stefan Dirsch from comment #15)
> (In reply to OBSbugzilla Bot from comment #14)
> > This is an autogenerated message for OBS integration:
> > This bug (1226725) was mentioned in
> > https://build.opensuse.org/request/show/1183326 Factory / Mesa
> 
> Next try. If that doesn't help I will limit these new patches to s390x for
> the time being until this thing gets fixed upstream. Better wrong colors
> than no GL at all.

Unfortunately it didn't help. :-(


https://build.opensuse.org/request/show/1183566
Comment 17 Stefan Dirsch 2024-06-27 11:41:22 UTC
So meanwhile this one patch

commit 527051c7d7e37e748ed0a456d98ed0f549cca745
Author: Daniel Stone <daniels@collabora.com>
Date:   Fri Jun 21 11:24:31 2024 +0100

    dri: Fix BGR format exclusion

was added to Mesa 24.1 branch and recently reverted without any useful comment.


commit 1db8a531d8e3a4557a280873e913b8b2d8f617f8 (HEAD -> 24.1, origin/staging/24
.1)
Author: Eric Engestrom <eric@igalia.com>
Date:   Wed Jun 26 20:18:51 2024 +0200

    Revert "dri: Fix BGR format exclusion"
    
    This reverts commit 527051c7d7e37e748ed0a456d98ed0f549cca745.

So I guess Eric stumbled across broken colors as well with that patch.
Comment 18 Stefan Dirsch 2024-06-27 11:53:19 UTC
I think I figured out why it has been reverted. Seems it was already noticed and reported by others.

https://gitlab.freedesktop.org/mesa/mesa/-/issues/11398
Comment 19 OBSbugzilla Bot 2024-06-28 13:45:01 UTC
This is an autogenerated message for OBS integration:
This bug (1226725) was mentioned in
https://build.opensuse.org/request/show/1183856 Factory / Mesa
Comment 20 Dominique Leuenberger 2024-06-28 18:55:19 UTC
*** Bug 1227173 has been marked as a duplicate of this bug. ***
Comment 21 Sarah Kriesch 2024-06-30 10:53:26 UTC
Our openQA tests have been passed 6 hours ago. It seems to be fixed for s390x.
Thanks!
Comment 22 Stefan Dirsch 2024-06-30 14:37:04 UTC
Wow! Still can't believe that! But for now let's assume this being real. Closing as fixed therefore.