Bug 1226796 (CVE-2024-34777)

Summary:	VUL-0: CVE-2024-34777: kernel: dma-mapping: benchmark: fix node id validation
Product:	[Novell Products] SUSE Security Incidents	Reporter:	SMASH SMASH <smash_bz>
Component:	Incidents	Assignee:	Security Team bot <security-team>
Status:	RESOLVED FIXED	QA Contact:	Security Team bot <security-team>
Severity:	Normal
Priority:	P3 - Medium	CC:	camila.matos, mhocko
Version:	unspecified
Target Milestone:	---
Hardware:	Other
OS:	Other
URL:	https://smash.suse.de/issue/411779/
Whiteboard:	CVSSv3.1:SUSE:CVE-2024-34777:6.1:(AV:L/AC:L/PR:L/UI:N/S:U/C:L/I:N/A:H)
Found By:	Security Response Team	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description SMASH SMASH 2024-06-21 16:16:38 UTC

In the Linux kernel, the following vulnerability has been resolved:

dma-mapping: benchmark: fix node id validation

While validating node ids in map_benchmark_ioctl(), node_possible() may
be provided with invalid argument outside of [0,MAX_NUMNODES-1] range
leading to:

BUG: KASAN: wild-memory-access in map_benchmark_ioctl (kernel/dma/map_benchmark.c:214)
Read of size 8 at addr 1fffffff8ccb6398 by task dma_map_benchma/971
CPU: 7 PID: 971 Comm: dma_map_benchma Not tainted 6.9.0-rc6 #37
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996)
Call Trace:
 <TASK>
dump_stack_lvl (lib/dump_stack.c:117)
kasan_report (mm/kasan/report.c:603)
kasan_check_range (mm/kasan/generic.c:189)
variable_test_bit (arch/x86/include/asm/bitops.h:227) [inline]
arch_test_bit (arch/x86/include/asm/bitops.h:239) [inline]
_test_bit at (include/asm-generic/bitops/instrumented-non-atomic.h:142) [inline]
node_state (include/linux/nodemask.h:423) [inline]
map_benchmark_ioctl (kernel/dma/map_benchmark.c:214)
full_proxy_unlocked_ioctl (fs/debugfs/file.c:333)
__x64_sys_ioctl (fs/ioctl.c:890)
do_syscall_64 (arch/x86/entry/common.c:83)
entry_SYSCALL_64_after_hwframe (arch/x86/entry/entry_64.S:130)

Compare node ids with sane bounds first. NUMA_NO_NODE is considered a
special valid case meaning that benchmarking kthreads won't be bound to a
cpuset of a given node.

Found by Linux Verification Center (linuxtesting.org).

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-34777
https://git.kernel.org/pub/scm/linux/security/vulns.git/plain/cve/published/2024/CVE-2024-34777.mbox
https://git.kernel.org/stable/c/35d31c8bd4722b107f5a2f5ddddce839de04b936
https://git.kernel.org/stable/c/c57874265a3c5206d7aece3793bb2fc9abcd7570
https://git.kernel.org/stable/c/34a816d8735f3924b74be8e5bf766ade1f3bd10b
https://git.kernel.org/stable/c/63e7e05a48a35308aeddd7ecccb68363a5988e87
https://git.kernel.org/stable/c/1ff05e723f7ca30644b8ec3fb093f16312e408ad
https://www.cve.org/CVERecord?id=CVE-2024-34777
https://bugzilla.redhat.com/show_bug.cgi?id=2293642

Comment 2 Michal Hocko 2024-06-25 08:18:55 UTC

git grep CONFIG_DMA_MAP_BENCHMARK origin/SLE15-SP5 -- config
origin/SLE15-SP5:config/arm64/default:# CONFIG_DMA_MAP_BENCHMARK is not set
origin/SLE15-SP5:config/armv7hl/default:# CONFIG_DMA_MAP_BENCHMARK is not set
origin/SLE15-SP5:config/ppc64le/default:# CONFIG_DMA_MAP_BENCHMARK is not set
origin/SLE15-SP5:config/s390x/default:# CONFIG_DMA_MAP_BENCHMARK is not set
origin/SLE15-SP5:config/s390x/zfcpdump:# CONFIG_DMA_MAP_BENCHMARK is not set
origin/SLE15-SP5:config/x86_64/default:# CONFIG_DMA_MAP_BENCHMARK is not set

so we are not affected