Bug 1227717 (CVE-2024-39495)

Summary: VUL-0: CVE-2024-39495: kernel: greybus: fix use-after-free bug in gb_interface_release due to race condition
Product: [Novell Products] SUSE Security Incidents Reporter: SMASH SMASH <smash_bz>
Component: IncidentsAssignee: Security Team bot <security-team>
Status: RESOLVED INVALID QA Contact: Security Team bot <security-team>
Severity: Normal    
Priority: P3 - Medium CC: camila.matos, mhocko
Version: unspecified   
Target Milestone: ---   
Hardware: Other   
OS: Other   
URL: https://smash.suse.de/issue/413810/
Whiteboard: CVSSv3.1:SUSE:CVE-2024-39495:5.8:(AV:L/AC:H/PR:L/UI:N/S:U/C:L/I:L/A:H)
Found By: Security Response Team Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description SMASH SMASH 2024-07-12 14:55:10 UTC
In the Linux kernel, the following vulnerability has been resolved:

greybus: Fix use-after-free bug in gb_interface_release due to race condition.

In gb_interface_create, &intf->mode_switch_completion is bound with
gb_interface_mode_switch_work. Then it will be started by
gb_interface_request_mode_switch. Here is the relevant code.
if (!queue_work(system_long_wq, &intf->mode_switch_work)) {
	...
}

If we call gb_interface_release to make cleanup, there may be an
unfinished work. This function will call kfree to free the object
"intf". However, if gb_interface_mode_switch_work is scheduled to
run after kfree, it may cause use-after-free error as
gb_interface_mode_switch_work will use the object "intf".
The possible execution flow that may lead to the issue is as follows:

CPU0                            CPU1

                            |   gb_interface_create
                            |   gb_interface_request_mode_switch
gb_interface_release        |
kfree(intf) (free)          |
                            |   gb_interface_mode_switch_work
                            |   mutex_lock(&intf->mutex) (use)

Fix it by canceling the work before kfree.

References:
http://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2024-39495
https://www.cve.org/CVERecord?id=CVE-2024-39495
https://git.kernel.org/stable/c/03ea2b129344152157418929f06726989efc0445
https://git.kernel.org/stable/c/0b8fba38bdfb848fac52e71270b2aa3538c996ea
https://git.kernel.org/stable/c/2b6bb0b4abfd79b8698ee161bb73c0936a2aaf83
https://git.kernel.org/stable/c/5c9c5d7f26acc2c669c1dcf57d1bb43ee99220ce
https://git.kernel.org/stable/c/74cd0a421896b2e07eafe7da4275302bfecef201
https://git.kernel.org/stable/c/9a733d69a4a59c2d08620e6589d823c24be773dc
https://git.kernel.org/stable/c/fb071f5c75d4b1c177824de74ee75f9dd34123b9
Comment 3 Michal Hocko 2024-07-12 15:25:07 UTC
We do not enable CONFIG_GREYBUS in any of our products.