Bug 128354

Summary:	Patch pango to support localized font family and style name.
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Zhe Su <zsu>
Component:	GNOME	Assignee:	E-mail List <gnome-bugs>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Enhancement
Priority:	P5 - None	CC:	federico
Version:	Alpha 1
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	The patch against pango 1.10.1 An optimized patch. A new patch wich has been posted to upstream bugzilla.

Description Zhe Su 2005-10-14 10:00:42 UTC

Many fonts have localized family or style name, and new fontconfig supports such
informations. The attached patch will let pango use localized font family and
style name if available.

Comment 1 Zhe Su 2005-10-14 10:03:45 UTC

Created attachment 54050 [details]
The patch against pango 1.10.1

With this patch. gtk based applications will use localized font family and style name when possible. It will be more easier for users to choose fonts.

Comment 2 Stanislav Brabec 2005-10-14 11:04:39 UTC

Patch added to STABLE and PLUS. Could you send the patch upstream and then close
this bug with reference to upstream bug? Thanks.

Comment 3 Zhe Su 2005-10-14 14:32:35 UTC

I just searched the upstream bugzilla and found the similar bug report:
http://bugzilla.gnome.org/show_bug.cgi?id=95731

It seems that Owen Taylor has different idea for this bug. I'll try to fix this
bug with Owen's idea, and submit a new patch as soon as possible.

However, my apporach is much simpler than Owen's idea and won't break binary
compatibility.
With Owen's idea, all applications/libraries which uses pango library should be
patched to use the new APIs. It's more difficult but clean.

Comment 4 Zhe Su 2005-10-15 05:40:27 UTC

Created attachment 54199 [details]
An optimized patch.

Comment 5 Zhe Su 2005-10-15 07:32:02 UTC

Created attachment 54200 [details]
A new patch wich has been posted to upstream bugzilla.

See bugzilla.gnome.org/show_bug.cgi?id=95731

Comment 6 Stanislav Brabec 2005-10-17 09:24:22 UTC

Patch from comment #1 was rejected by Autobuild team:

Are we sure that get_current_language_tag() always returns a null-terminated string?
de_DE@EURO is longer than 6 bytes...

Looking at your new patch, there should be not problem with it. Should I submit it to Autobuild?

Comment 7 Zhe Su 2005-10-17 13:57:30 UTC

I'm currently hacking fontconfig to return localized font family and style name. This patch should not be necessary anymore, if it's successful. And all other applications which use fontconfig should be ok as well.

So please wait some more days.

Comment 8 Zhe Su 2005-10-18 07:02:56 UTC

I proposed a patch for fontconfig in bug #128930. If you think that patch is ok, then we can close this bug as WONTFIX.

Comment 9 Zhe Su 2005-10-20 23:50:52 UTC

With patch from bug #128930 for fontconfig. This patch is not necessary anymore.