Bug 128616

Summary: powersaved should load cpufreq_conservative module
Product: [openSUSE] SUSE Linux 10.1 Reporter: Alexander Lavrinenko <lavrinenko_alex>
Component: BasesystemAssignee: Holger Macht <hmacht>
Status: VERIFIED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Enhancement    
Priority: P5 - None CC: behlert
Version: Alpha 1   
Target Milestone: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Alexander Lavrinenko 2005-10-16 07:36:12 UTC
I found that powersaved initscript does not load conservative governor that is 
preferred over ondemand for laptops. Please update /etc/init.d/powersaved, 
function load_governors(), just below ondemand loader: 
 
    case "$govs" in 
        *conservative*) 
            ;; 
        *) 
            modprobe -q cpufreq_conservative >/dev/null 2>&1 
            [ $? != 0 ] && $LOGGER conservative cpufreq governor could not be 
loaded 
            ;; 
    esac 
 
TIA
Comment 1 Thomas Renninger 2005-10-17 09:29:50 UTC
Hmm, I am not happy about the kernel governors at the moment. There are enough bug reports and not running machines with the ondemand governor, specially SMP and PIII-M machines had a lot of problems in the past with kernel governors.
To support and set configs for the conservative governor there is more work needed.
Use the userspace governor, it runs more stable and should save the same amount of battery than conservative governor (show figures if not).
Seife might also want to comment on this one.
Comment 2 Thomas Renninger 2005-10-17 09:30:40 UTC
On longterm we might want to support it... will reopen as enhancement.
Comment 3 Thomas Renninger 2005-12-14 14:35:24 UTC
Seife, will we add this governor? I think it's not worth it?
Could you please go on with this bug or just close if you think we don't need this governor or better: If you think supporting it is not a good idea...
Comment 4 Holger Macht 2005-12-14 14:42:22 UTC
For what reasons is this governor especially helpful? It should be easy to add a configuration variable and if set, the conservative governor is used instead of the ondemand governor. But I do not exactly know what are the advantages towards the ondemand governor, though.
Comment 5 Forgotten User ZhJd0F0L3x 2005-12-14 14:47:45 UTC
we could add it, but i think it is not as simple as just changing the init script.
Alexander, have you actually tried it? IIRC (i am not fluent with the latest code) we write the governor to use into the sysfs file from the daemon to be able to switch from kernelspace to userspace, so the daemon needs at least to know about which kernel governor to use.
I will look at it, but this is rather low priority right now, since the userspace implementation is well proven, feature rich and works on a larger variety of hardware than the kernel governors and does basically behave like cpufreq_conservative is designed to.

I'd take a patch for powersaved of course ;-)
Comment 6 Forgotten User ZhJd0F0L3x 2005-12-14 14:48:58 UTC
Holger: the conservative governor is a "slow ondemand" governor, which is primary keeping the frequency as low as possible and not tuned for fastest system performance (whcih the ondemand governor is).
Comment 7 Holger Macht 2005-12-14 14:56:00 UTC
Yes I know this, but it also stais longer at an high frequency until it switches back to a low one. Therefor I'm not sure whether it really saves much more power then the userspace governor or even ondemand governor.
Comment 8 Alexander Lavrinenko 2005-12-14 17:09:25 UTC
Yes, Stephan, I used it a while on my prev. laptop - Toshiba Satellite Pro M30. Frankly, I hadn't noticed much obvious difference between ondemand and conservative, but since kernel people wrote it I think it's worth support it.
Holger, if it stays longer in upper freq range than maybe it's time to open bug at kernel.org regarding this? In my opinion, both conservative and ondemand are useful for laptops, the difference is conservative is good for running on battery while ondemand - for running on mains...
Comment 9 Holger Macht 2005-12-15 09:26:33 UTC
Ok, I will do some more testing on that and if it is worth to use the conservative governor when being on battery, we should support it IMO. But as Stefan already mentioned, this is only some kind of enhancement and will go in as time permits.
Comment 12 Stefan Behlert 2006-10-18 12:47:19 UTC
Ok, this bug is inactive for quite some time. Please decide if there's some work left to do or if it can be closed.
Comment 13 Forgotten User ZhJd0F0L3x 2006-10-18 13:06:58 UTC
Holger, was your research successful?
Comment 14 Forgotten User ZhJd0F0L3x 2006-10-18 13:26:38 UTC
Ok, we now load cpufreq_conservative. It is, however, up to the applications that use the hal-cpufreq-addon to use it.