Bug 128937

Summary:	patch to add FC_EMBEDDED_BITMAP object into fontconfig.
Product:	[openSUSE] SUSE Linux 10.1	Reporter:	Zhe Su <zsu>
Component:	Basesystem	Assignee:	Mike Fabian <mfabian>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Normal
Priority:	P5 - None
Version:	Alpha 1
Target Milestone:	---
Hardware:	Other
OS:	Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---
Attachments:	The patch against fontconfig 2.3.91

Description Zhe Su 2005-10-18 07:31:38 UTC

Currently our fontconfig doesn't have builtin FC_EMBEDDED_BITMAP object. We use
it as user defined object, however it's not a standard way.
The attached patch adds FC_EMBEDDED_BITMAP as a standard builtin object.
There is also a similar bug report and patch in upstream bugzilla.
Hope it could be adopted by upstream.

Comment 1 Zhe Su 2005-10-18 07:37:14 UTC

Created attachment 54477 [details]
The patch against fontconfig 2.3.91

Comment 2 Zhe Su 2005-10-18 07:39:44 UTC

See also upstream bug report https://bugs.freedesktop.org/show_bug.cgi?id=4763
The only difference between my patch and the upstream patch is the default value of FC_EMBEDDED_BITMAP object. I'd like to turn off embedded bitmap by default.

Comment 3 Mike Fabian 2005-10-26 10:13:18 UTC

The patch from https://bugs.freedesktop.org/show_bug.cgi?id=4763
by Jinghua Luo <sunmoon1997@gmail.com> is included in the CVS of
fontconfig now (fontconfig 2.4 branch).

Comment 4 Mike Fabian 2005-10-27 14:19:29 UTC

OK, I added the missing part of your patch to the fontconfig 2.3.91.20051026
package which I submitted to BETA:

mfabian@magellan:/work/src/done/BETA/fontconfig$ cat bugzilla-128937-turn-off-embedded-bitmaps-by-default.patch
diff -ru fontconfig-2.3.91.20051026.orig/src/fcdefault.c fontconfig-2.3.91.20051026/src/fcdefault.c
--- fontconfig-2.3.91.20051026.orig/src/fcdefault.c	2005-10-26 11:26:44.000000000 +0200
+++ fontconfig-2.3.91.20051026/src/fcdefault.c	2005-10-27 15:19:10.000000000 +0200
@@ -33,7 +33,7 @@
     { FC_VERTICAL_LAYOUT,   FcFalse	},  /* FC_LOAD_VERTICAL_LAYOUT */
     { FC_AUTOHINT,	    FcFalse	},  /* FC_LOAD_FORCE_AUTOHINT */
     { FC_GLOBAL_ADVANCE,    FcTrue	},  /* !FC_LOAD_IGNORE_GLOBAL_ADVANCE_WIDTH */
-    { FC_EMBEDDED_BITMAP,   FcTrue 	},  /* !FC_LOAD_NO_BITMAP */
+    { FC_EMBEDDED_BITMAP,   FcFalse 	},  /* !FC_LOAD_NO_BITMAP */
 };
 
 #define NUM_FC_BOOL_DEFAULTS	(int) (sizeof FcBoolDefaults / sizeof FcBoolDefaults[0])
mfabian@magellan:/work/src/done/BETA/fontconfig$

That way it doesn't get lost and will automatically appear in STABLE
again when we have fixed the crashes in fontconfig (see bug #128080)
and move the fontconfig from BETA to STABLE again.

Comment 5 Mike Fabian 2005-10-27 14:20:08 UTC

Closing this bug as FIXED.