Bug 129209

Summary: unsermake has two little bugs creating shell commands
Product: [openSUSE] SUSE LINUX 10.0 Reporter: Dennis Lubert <plasmahh>
Component: DevelopmentAssignee: Stephan Kulow <coolo>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Dennis Lubert 2005-10-18 21:21:22 UTC 
Hi,

when trying to use unsermake to compile qtparted (which is sadly not in suse) I
encountered two little bugs in the suite that caused to try to execut a "$ret" =
0 cmd in the shell instead of "$ret" == 0. they are:

designer.um: line 88 it must be:
rules.append( "if test \"$$ret\" == 0; then echo '#include \"%s.moc\"' >> %s;
else         rm -f %s; exit $$ret; fi"

and program.py:432 it must be:
'if test "$$stat" = 0; then echo "timestamp" > %s; fi' % closure])

greets

Dennis
Comment 1 Dennis Lubert 2005-10-18 21:37:25 UTC 
another addition, in designer.um line 84 and 81 need the "ret=$$?" to be ended by an ; to properly end this cmd for the shell
Comment 2 Stephan Kulow 2005-10-19 11:46:05 UTC 
I have no idea what you're talking about, sorry. Please provide a patch (against websvn.kde.org/trunk/kdenonbeta/unsermake)
Comment 3 Dennis Lubert 2005-10-21 21:56:50 UTC 
it looks like in the svn version the bugs are fixed, maybe the package should be upgraded ?
Comment 4 Stephan Kulow 2006-02-04 15:54:51 UTC 
it is updated often