Bug 129753

Summary: Localize font style name in gtk font selection dialog and font button.
Product: [openSUSE] SUSE Linux 10.1 Reporter: Zhe Su <zsu>
Component: GNOMEAssignee: E-mail List <gnome-bugs>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: federico
Version: Alpha 1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Attachments: Patch for gtk 2.8.6 to localize the commonly used font style names.
bugzilla-129753-gtk+-2.8.9-localize-font-style-name.diff
gedit-font-selection-dialog-with-patch-german.png

Description Zhe Su 2005-10-20 15:35:35 UTC
currently, gtk2 just uses the original font style names to display in font
selection dialog and font button. But the style names in most fonts are not
localized, so it's not comfortable for most non-English users.

I'll post a patch for gtk 2.8.6 to make the commonly used style names
localizable in po files.
Comment 1 Stanislav Brabec 2005-10-20 15:41:53 UTC
Will this patch obsolete bug 128354?
Comment 2 Zhe Su 2005-10-20 15:45:24 UTC
Created attachment 54979 [details]
Patch for gtk 2.8.6 to localize the commonly used font style names.

I only updated the zh_CN and zh_TW po files.
Hope the update for zh_TW is ok :-)
Comment 3 Zhe Su 2005-10-20 23:54:09 UTC
This patch is nothing to do with bug 128354. This patch puts the commonly used English style names into po files, so that they can be localized.

Bug 128354 is talking about using localized style names stored in the font files.
However I closed bug 128354 as WONTFIX, because of bug 128930 addresses that issue as well.
Comment 4 Zhe Su 2005-10-24 12:04:54 UTC
See also http://bugzilla.gnome.org/show_bug.cgi?id=319484
Comment 5 Zhe Su 2005-12-29 04:40:44 UTC
Do you have any update? Is it possible to merge this patch into our gtk2 package?
Comment 6 Federico Mena Quintero 2005-12-29 19:14:16 UTC
According to http://bugzilla.gnome.org/show_bug.cgi?id=95731#c6 and to https://bugzilla.novell.com/show_bug.cgi?id=128930#c17 users of fontconfig don't require changes if they are using a new fontconfig.  Is this accurate?  Or does GTK+ still need the changes from your patch?

I'm confused :)

In NLD/SuSE we always use fontconfig under Pango, don't we?
Comment 7 Zhe Su 2005-12-30 01:37:43 UTC
128930 and  this bug are not same. 

128930 is talking about making use of the localized family and style name STORED in font files.

However, most font files don't provide localized style name, so user will only see the latin style name, like Italic, Bold etc., even the patch for 128930 is applied .

However, it's not friendly for users. For many non-English users, they even don't know what's the meaning of words Italic and Bold. The patch of this bug addresses this issue by adding localized strings of those commonly used style names into po files, so that those style names will always be localized, no matter whether the fonts provide the localized names or not.
Comment 8 Zhe Su 2005-12-30 01:41:48 UTC
See also http://bugzilla.gnome.org/show_bug.cgi?id=123498
Comment 9 Mike Fabian 2005-12-30 15:29:44 UTC
Package with the patch applied submitted to STABLE:

-------------------------------------------------------------------
Fri Dec 30 14:29:34 CET 2005 - mfabian@suse.de

- Bugzilla #129753: Localize font style name in gtk font selection
  dialog and font button (add patch by Zhe Su <zsu@novell.com>).
  Patch updated for gtk+-2.8.9 and German translations of the
  style names added.

-------------------------------------------------------------------
Comment 10 Mike Fabian 2005-12-30 15:31:03 UTC
Created attachment 61829 [details]
bugzilla-129753-gtk+-2.8.9-localize-font-style-name.diff

patch updated for gtk+-2.8.9 with German translations added.
Comment 11 Mike Fabian 2005-12-30 15:32:05 UTC
Created attachment 61830 [details]
gedit-font-selection-dialog-with-patch-german.png

screen shot which shows that it works (using German).
Comment 12 Mike Fabian 2005-12-30 15:32:39 UTC
Closing as FIXED.