|
Bugzilla – Full Text Bug Listing |
| Summary: | dvbstream: array subscript out of range + local variable used before set | ||
|---|---|---|---|
| Product: | [openSUSE] openSUSE 11.0 | Reporter: | David Binderman <dcb314> |
| Component: | Network | Assignee: | Torsten Duwe <duwe> |
| Status: | RESOLVED UPSTREAM | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Minor | ||
| Priority: | P2 - High | ||
| Version: | Factory | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | openSUSE 11.0 | ||
| URL: | https://sourceforge.net/tracker/?func=detail&aid=2885125&group_id=50669&atid=460565 | ||
| Whiteboard: | |||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
part 1 of this bug report still exists in version 0.6-2, around 13 Dec 05 David, in case the issues are not introduced by a patch local to openSUSE please report the issues upstream. Packagers, please do not add openSUSE-local patches to fix this kind of errors but forward the bugs upstream and close the bugs as RESOLVED UPSTREAM. Note that it is perfectly fine to have "resource leaks" at the end of a program as the kernel will clean up for you. Manually freeing them only increases binary size and runtime. |
I just tried to compile package dvbstream-0.4pre2-390 with the Intel C compiler It said 1. mpegtools/remux.c(468): warning #175: subscript out of range The source code is uint8_t b[3]; vring_peek( rem, b, 4, 0); if ( b[0] == 0x00 && b[1] == 0x00 && b[2] == 0x01 && b[3] == 0xb3) found = 4; Clearly broken code. b[ 3] doesn't exist. Suggest code rework, but I don't have a suggested fix for this. 2. tune.c(202): warning #592: variable "fe_info" is used before its value is set The source code is switch(fe_info.type) { Suggest initialise local variable "fe_info" before first use.