Bug 130251

Summary: "quilt setup gcc.spec" creates a second series file in a subdirectory
Product: [openSUSE] SUSE LINUX 10.0 Reporter: Olaf Dabrunz <odabrunz>
Component: DevelopmentAssignee: Olaf Dabrunz <odabrunz>
Status: RESOLVED WONTFIX QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P4 - Low    
Version: RC 4   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.0   
Whiteboard:
Found By: Development Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Olaf Dabrunz 2005-10-24 11:43:42 UTC
How to reproduce:

- get the gcc sources (I took them from SLES9)
- quilt setup gcc.spec

> find . -depth -name "series"
./gcc-3.3.3/gcc/series
./gcc-3.3.3/series

In gcc.spec we have:

%prep 
%setup -q -n gcc-%{gcc_version}
%patch0 
%patch1
cd gcc
%patch2 
cd ..
%patch3
%patch4
[...]
%patch64 -p1
%patch65 -p1
cd gcc
%patch66
cd ..
%patch67
%patch68
[...]

So %patch2 and %patch66 get applied from within the gcc subdirectory and end up
in the gcc/series file.

Problem: depending on the current directory within the gcc sources, quilt
commands like "quilt push -a" and "quilt applied" behave differently.
Comment 1 Andreas Gruenbacher 2005-10-24 11:50:02 UTC
When in directory gcc-3.3.3, quilt has no way of applying a -p0 style patch to the sub-directory gcc. You'll have to change patch 2 so that it is applied from within gcc-3.3.3 instead of gcc-3.3.3/gcc.

Maybe the gcc folks are willing to change this?
Comment 2 Olaf Dabrunz 2005-10-24 15:05:10 UTC
I see.

One problem I see is that as long as patches from other sources are supposed to
remain "pristine", these patches should be accepted by the quilt tool as-is.

Also, AFAICR I have seen such patches (with one or more missing subdirectories)
several times in other packages as well. So it seems to happen often enough to
take care of this in quilt.
Comment 3 Olaf Dabrunz 2005-11-03 10:45:27 UTC
*** Bug 130262 has been marked as a duplicate of this bug. ***
Comment 4 Alexander Osthof 2007-05-10 12:18:36 UTC
Is this issue still valid for openSUSE 10.3?
Comment 5 Andreas Jaeger 2007-08-11 15:21:28 UTC
No reaction since more than 2 months, therefore closing as CANTFIX (aka WONTFIX).

If you can provide the needed information, feel free to reopen the bug.