Bug 130311

Summary: missing expression in return statement
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: OtherAssignee: E-mail List <bnc-team-screening>
Status: RESOLVED WONTFIX QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.0   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-10-24 17:00:00 UTC
I just tried to compile package geki2-2.0.3-358 with the GNU C compiler 

It said

ranking.c:17: warning: `return' with no value, in function returning non-void

The source code is

  if (i == 5)
    return;

I notice that the return type is void. I also notice that there is no
return statement at the end of the function.

It might be better to change the return type of the function from int to void.
Comment 1 Andreas Jaeger 2005-10-25 13:20:53 UTC
David, please send such warnings together with a patch to the upstream package author so that the next official release will contain that fix and we can use it.

thanks.
Comment 2 David Binderman 2005-10-26 10:58:48 UTC
(In reply to comment #1)
> David, please send such warnings together with a patch to the upstream package
> author so that the next official release will contain that fix and we can use
> it.

Righto. 

You only got the bug report because I couldn't find an upstream maintainer
in the package source code.

I'll have another look. If I still can't find an upstream maintainer, then I guess this bug report will go to /dev/null.



Comment 3 Michael Gross 2005-10-27 11:45:42 UTC
The maintainer is listed as pth@suse.de (Phillip Thomas).
Comment 4 Andreas Jaeger 2005-10-28 05:04:03 UTC
homepage is http://kxl.hn.org/, there should be an email address.
Comment 5 David Binderman 2005-10-28 09:38:34 UTC
>The maintainer is listed as pth@suse.de (Phillip Thomas).

Thanks for your help. 

I have emailed him, to point him at this bug report. 

Hopefully a new release soon ;->
Comment 6 Philipp Thomas 2005-10-28 13:59:35 UTC
I'm not the upstream maintainer, I'm just the SUSE maintainer for the package. The Author of geki2 is SATO Katsuyoshi <fc3srx7@mwnet.or.jp>. But I'll have a look at the package.