Bug 130321

Summary:	glabels-2.0: local variable used before set
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	David Binderman <dcb314>
Component:	Other	Assignee:	E-mail List <bnc-team-screening>
Status:	RESOLVED WONTFIX	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	Final
Target Milestone:	---
Hardware:	All
OS:	SuSE Linux 10.0
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description David Binderman 2005-10-24 17:15:43 UTC

I just tried to compile package glabels-2.0 with a recent snapshot
of the 4.1 version of the GNU C compiler 

It said

canvas-hacktext.c:304: warning: "text" is used uninitialized in this function

The source code is

	if (text) bp->text = g_value_dup_string (value);

Suggest initialise local variable "text" before first use.

Comment 1 Andreas Jaeger 2005-10-25 13:20:18 UTC

David, please send such warnings together with a patch to the upstream package author so that the next official release will contain that fix and we can use it.

thanks.

Comment 2 David Binderman 2005-10-26 11:51:30 UTC

(In reply to comment #1)
> David, please send such warnings together with a patch to the upstream package
> author so that the next official release will contain that fix and we can use
> it.

Will do, but you may consider it prudent to check that the email addresses
that you have in your *.spec files for the package authors are valid.

It makes it hard to report a bug if

a) the folks I got the software from deny all knowledge.
b) the email address of the author doesn't work.

Of the seven bugs I've just reported, five have come back with invalid
email addresses.