|
Bugzilla – Full Text Bug Listing |
| Summary: | X server crashes | ||
|---|---|---|---|
| Product: | [openSUSE] SUSE Linux 10.1 | Reporter: | Andreas Schwab <schwab> |
| Component: | X.Org | Assignee: | Stefan Dirsch <sndirsch> |
| Status: | RESOLVED FIXED | QA Contact: | Stefan Dirsch <sndirsch> |
| Severity: | Major | ||
| Priority: | P5 - None | CC: | eich, ekunze, mort, rw, susedev |
| Version: | Alpha 2plus | ||
| Target Milestone: | --- | ||
| Hardware: | IA64 | ||
| OS: | Other | ||
| Whiteboard: | ia64-graphics | ||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
| Attachments: |
xorg.conf
Patch to fix PCI domain support for Altix New patch lightly tested on Altix Alternative patch Tested patch better domain support detection Final patch Incremental patch to fix Bug #142039 |
||
|
Description
Andreas Schwab
2005-11-04 13:34:42 UTC
Created attachment 56480 [details]
xorg.conf
Ok. Nullpointer reference.
altixPCI.c:xf86PostScanAltix()
[...]
pdev = xf86scanpci(0);
prevBusNum = curBusNum = pdev[0]->busnum;
^^^^^^^
Pretty new this stuff. See also Bug X.Org #2373
https://bugs.freedesktop.org/show_bug.cgi?id=2373
Assigning to Egbert, since he already looked at this before.
SGI, would you mind also looking into this? Graphics enablement... Forthcoming patch will be attached to: Bug 5000: Domain support does not work for SGI Altix machines https://bugs.freedesktop.org/show_bug.cgi?id=5000 Thanks. I've added myself to Cc now. Created attachment 56955 [details]
Patch to fix PCI domain support for Altix
Patch from X.Org Bugzilla (#5000).
"This patch works on Altix, and should fall back correctly on other platforms."
*** Bug 133236 has been marked as a duplicate of this bug. *** From looking at this patch I cannot find anything that appears to be questionable. The patch attempts to be less intrusive than would normally be. Please test it on one or two non-Altix to verify this in reality. Then I don't have any problems with this patch going in. I will revisit the PCI domain issue later. The patch does the wrong thing for non-SGI systems. It causes all pci devices to be enumerated multiple time (once for each possible domain). The change in linuxOpenLegacy also does not make any sense. Rather xf86GetPciDomain should be changed. But this is not the cause of the problem. The problem comes from linuxPciOpenFile(). I'm looking for the best fix. Created attachment 58767 [details]
New patch lightly tested on Altix
Created attachment 58769 [details]
Alternative patch
This one's much faster at startup.
I readded the '- 1' in openLegacy. without it the fallback code is called all the time.
IMHO the change in xf86GetPciDomain is still needed, but I haven't tested it yet. Domain 0 is treated special. I don't know why. The author of domain support has added some incredible complexity. This will go once I revisit this code. As long as this isn't changed we may have to start numbering with 1. I know - this is ugly. The last patch does not work. Just because a specific pci bus does not exist does not mean that domains are not supported at all. Created attachment 58776 [details]
Tested patch
This patch is tested and works, both on Altix and other systems.
Created attachment 58825 [details]
better domain support detection
This patch should fix the problem with the domain detection and speeds up startup considerably. I have only test on zx2000 at the moment, though.
When bus >= 256 you should use %04x for printing (twice). -sprintf(file, "/proc/bus/pci/%04x:%02x", domain, bus); +sprintf(file, "/proc/bus/pci/%04x:%04x", domain, bus); -sprintf(file, "/proc/bus/pci/%04x:%02x/%02x.%1x", +sprintf(file, "/proc/bus/pci/%04x:%04x/%02x.%1x", The patch only builds if INCLUDE_XF86_NO_DOMAIN is not defined. Created attachment 58912 [details]
Final patch
> Final patch
Egbert, can you confirm this?
Yes.
I forgot to add the:
+ #ifndef INCLUDE_XF86_NO_DOMAIN
domain_support = linuxDomainSupport();
+ #endif
and of course the sprintf changes are correct.
Thanks. I'll take care of this now. xorg-x11 package submitted for STABLE (fixed for Alpha4). Created attachment 63024 [details] Incremental patch to fix Bug #142039 Andreas Schwab made a patch, which fixes Bug #142039. |