Bug 132478

Hi,

I will refer to the apcupsd version coming in SUSE 10.0 (3.10.17a-3) and also to the apcupsd version on Alpha 10.1 (3.10.18).  Both rpm's run almost exactly the same "after installation scripts".

The basic idea is this: After you install this rpm, it will create a couple of lines in /etc/init.d/halt.local.  The problem is that init.local is called (by halt) too early in the process (apcupsd-wise).
 
The lines in /etc/init.d/halt.local will invoke apcupsd in order to send a signal to the UPS so it can shutdown itself. This is of course, after a power failure.  After a power failure, the apcupsd daemon will detect this and will create /etc/apcupsd/powerfail (a flag that will be used later on the shutdown sequence to determine if it's needed to send signal to UPS to shut down).
 
The lines in halt.local (after installing this rpm) have several errros (logic errors). Here are some:

1- filesystems are being remounted read-only when there is no need since at this point nothing has been unmounted.
 
2- there are some kill lines in here (sigterm and sigkill). It's not ncesseary a t this point since these kills are going to be performed later on the halt script (so there's no need for halt.local to include those).  Also, you're killing some necesarry processes too early in the process...

After running the commands in halt.local...there are going to be a couple of errors (when resuming the halt script).

Also, we need to perform this apcupsd thing at the very end of the halt script. If there's a powerfailure apcupsd will send signal to UPS to shutdown. Most UPS'es have a grace period and won't turn off right-away...but we don't know every UPS out there...so we need to play safe and put it almost at the end.

Things to consider for this post-installation-script:

- we need to place the apcupsd lines at the very end before "halt -p"
- we're going to invoke /sbin/apcupsd and we're going to read files from /etc so we must make sure we have access to /sbin and /etc...(check if filesystems are mounted..if not...we need to mount them read-only)


We can do two things:

- place corresponding lines almost at the very end of /etc/init.d/halt (just like the make process does when we compile apcupsd from source)

or

- place a call line almost at the end of halt...we call a file called: apcupsd.local 


Here's a snipped taken from the apcupsd tree that will place the aproppiate lines almost at the end of halt:

cp -f /etc/init.d/halt /etc/init.d/halt.old
awk -f awkhaltprog.in /etc/init.d/halt.old > /etc/init.d/halt


I will attach awkhaltprog.in

The only thing missing here is the verification of mounted filesystems and the read-only mounting of those unmounted.  In my case, (I just compiled from source) it worked (like above) since I have everything under / and at this poing (of halt) / is mounted read-only....

Sorry for my english!

Jorge