Bug 133611

Summary:	loki_setup-1.6.1_20041219-6: dodgy looking code
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	David Binderman <dcb314>
Component:	Basesystem	Assignee:	Ludwig Nussel <lnussel>
Status:	RESOLVED INVALID	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	Final
Target Milestone:	---
Hardware:	All
OS:	SuSE Linux 10.0
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description David Binderman 2005-11-13 16:22:49 UTC

I just tried to compile package loki_setup-1.6.1_20041219-6 with a 
prerelease of version 4.1 of the GNU C compiler.

It said

gtk_ui.c:1025: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

The source code is

	if (i > sizeof(install_paths) > sizeof(install_paths[0])) {

Suggest code rework.

Comment 1 Ludwig Nussel 2005-11-14 10:45:53 UTC

Feel free to send a patch upstream :-)

Comment 2 Ted Bullock 2007-07-09 01:18:29 UTC

Closing as invalid due to lack of clarity, activity and follow up from reporter.