Bug 133612

Summary: openafs-1.3.85-3: three buglets
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Ales Nosek <anosek>
Status: RESOLVED WONTFIX QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.0   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-11-13 17:11:48 UTC 
I just tried to compile package openafs-1.3.85-3 with a non standard version
of the GNU C compiler.

It said

1.

/usr/src/packages/BUILD/openafs-1.3.85/src/afs/UKERNEL/osi_vnodeops.c:62: warning: `return' with no value, in function returning non-void

The source code is

int
afs_inactive(struct vcache *avc, struct AFS_UCRED *acred)
{
    struct vnode *vp = AFSTOV(avc);
    if (afs_shuttingdown)
        return;

Suggest code rework.

2.

/usr/src/packages/BUILD/openafs-1.3.85/src/afs/afs_pioctl.c:640: warning: `return' with no value, in function returning non-void

The source code is

	return;

Suggest code rework.

3.

./../rxkad/rxkad_common.c:190: warning: array subscript out of range
./../rxkad/rxkad_common.c:191: warning: array subscript out of range

The source code is

	rxkad_stats->spares[8] += thr_stats->spares[8];
	rxkad_stats->spares[9] += thr_stats->spares[9];

but

    long spares[8];

so spares[8] and spares[9] do not exist. Suggest code rework.
Comment 1 Ales Nosek 2006-09-18 06:45:23 UTC 
Thank you for the report. We won't fix this bug, package openafs was dropped.