Bug 134587

Summary: ted-2.17-2: dodgy code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Ladislav Michnovic <lmichnovic>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: SuSE Linux 10.0   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-11-20 18:33:20 UTC 
Hello there,

I just tried to compile package ted-2.17-2 with the GNU C compiler.

It said

appTree.c:359: warning: comparisons like X<=Y<=Z do not have their mathematical meaning

The source code is

    if  ( ( ! tn->tnParent || tn->tnIsOpen )    &&
          tn->tnChildCount > 0                  > 0 )

Suggest code rework.


Regards

David Binderman
Comment 1 Ladislav Michnovic 2005-11-21 18:22:35 UTC 
I'm working on it.
Comment 2 Ladislav Michnovic 2005-11-30 17:25:49 UTC 
Code reworked.