Bug 136788

Summary: gwget-0.95-3: undefined C code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Ladislav Michnovic <lmichnovic>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-12-02 22:29:09 UTC
Hello there,

I just tried to compile package gwget-0.95-3 with a prerelease of the
GNU C compiler version 4.1. It said

wget-log.c:42: warning: operation on `p' may be undefined

The source code is

	while (*p != ' ')
		*p++ = *(p+1);

I agree with the compiler - this code seems to be undefined. 

Suggest new code

	while (*p != ' ')
	{
		p[ 0] = p[ 1]);
		++p;
	}

BTW, the email address of the author [ frimost@dhis.org ]
seems broken
Comment 1 Ladislav Michnovic 2005-12-05 20:41:49 UTC
Code fixed.