|
Bugzilla – Full Text Bug Listing |
| Summary: | libwmf-0.2.8.2-95: undefined C code | ||
|---|---|---|---|
| Product: | [openSUSE] SUSE LINUX 10.0 | Reporter: | David Binderman <dcb314> |
| Component: | Basesystem | Assignee: | Vladimir Nadvornik <nadvornik> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Minor | ||
| Priority: | P5 - None | ||
| Version: | Final | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | SuSE Linux 10.0 | ||
| Whiteboard: | |||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
I forgot to mention that the email address of the author is broken [ Caolan.McNamara@ul.ie ] fixed for 10.1 beta3, including email of the author. |
I just tried to compile package libwmf-0.2.8.2-95 with a prerelease of the GNU C compiler version 4.1. It said 1. gd_gd2.c:641: warning: operation on `chunkPos' may be undefined The source code is ch = chunkBuf[chunkPos++] << 24 + chunkBuf[chunkPos++] << 16 + chunkBuf[chunkPos++] << 8 + chunkBuf[chunkPos++]; I agree with the compiler - this code seems to be undefined. Suggest code rework. Maybe ch = chunkBuf[chunkPos] << 24 + chunkBuf[chunkPos + 1] << 16 + chunkBuf[chunkPos + 2] << 8 + chunkBuf[chunkPos + 3]; chunkPos += 4; might be ok.