Bug 136852

Summary:	kphone-4.2-4: undefined C code
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	David Binderman <dcb314>
Component:	Basesystem	Assignee:	Ruediger Oertel <ro>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	Final
Target Milestone:	---
Hardware:	All
OS:	SuSE Linux 10.0
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description David Binderman 2005-12-04 17:19:39 UTC

I just tried to compile package kphone-4.2-4 with a prerelease of the
GNU C compiler version 4.1. It said

1.

iCBSearch.cpp:130: warning: operation on "pp" may be undefined

The source code is

               for (j=0; j<lTarget; j++) {
                   *ppe+=(*pp)*(*pp++);
               }

I agree with the compiler - this code seems to be undefined. 

Suggest new code

               for (j=0; j<lTarget; j++) {
                   *ppe+=(*pp)*(*pp);
					++pp;
               }
2.

iCBSearch.cpp:325: warning: operation on "pp" may be undefined

Duplicate.

BTW, it seems that the orignal author [ vektor@div8.net ]
is no longer the maintainer of the code.

Comment 1 Ruediger Oertel 2005-12-16 11:32:16 UTC

thanks a lot for the spotting, fixed for next release.