Bug 137566

Summary: bmp-plugins-0.9.7-12: undefined C code
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Hendrik Vogelsang <hvogel>
Status: RESOLVED WONTFIX QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: Final   
Target Milestone: ---   
Hardware: All   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-12-08 12:43:02 UTC
I just tried to compile package bmp-plugins-0.9.7-12 with a prerelease of the
GNU C compiler version 4.1. It said

1.

sndfile.cpp:1174: warning: operation on "pSample" may be undefined

The source code is

                                *pSample++ = bswapLE16(*pSample);


I agree with the compiler - this code seems to be undefined. 

AFAIK, there are no guarantees in C that the side effects on the left of an
assignment happens before or after the right side effects.

Suggest code rework.

2.

sndfile.cpp:1365: warning: operation on "pSample" may be undefined

Duplicate.


BTW, I've already tried emailing who I thought was the author 
[ jeremytan@users.sourceforge.net ], without success.
Comment 1 Hendrik Vogelsang 2006-01-16 14:49:28 UTC
please talk to the authors of libmodplug

http://sourceforge.net/projects/modplug-xmms/

so we can pick it up from there
Comment 2 David Binderman 2006-01-16 22:09:10 UTC
>please talk to the authors of libmodplug

I tried that, and it didn't work.

It looks like this bug report goes to /dev/null
Comment 3 Hendrik Vogelsang 2006-05-18 11:10:31 UTC
we will drop bmp and bmp-plugins for the next version.