Bug 141064

Summary: jfsutils-1.1.10-2: bad function definition
Product: [openSUSE] SUSE LINUX 10.0 Reporter: David Binderman <dcb314>
Component: BasesystemAssignee: Mads Martin Joergensen <mmj>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Minor    
Priority: P5 - None    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: SUSE Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description David Binderman 2005-12-27 14:51:23 UTC 
I just tried to compile package jfsutils-1.1.10-2 with the Intel C compiler 

It said

dirindex.c(203): warning #1011: missing return statement at end of non-void function "dirty_index_page"
dirindex.c(200): warning #117: non-void function "dirty_index_page" should return a value

The source code is

static int dirty_index_page(struct dir_table_slot *table)
{
        /* Should only be called on most recent page */
        if (table != mru_di_page->table) {
                /* Really shoudn't happen. */
                printf("You messed up, Shaggy.  write_index_page mismatch.\n");
                return;
        }
        mru_di_page->flag |= DIPAGE_DIRTY;
}

So the return statement is missing an expression, and there is a missing
return statement at the end of the routine.
Comment 1 Mads Martin Joergensen 2006-01-11 15:40:45 UTC 
Yeah, that function should be void. Fixed.