Bug 141851

Summary:	sane-frontends-1.0.14-2: array subscript out of range
Product:	[openSUSE] SUSE LINUX 10.0	Reporter:	David Binderman <dcb314>
Component:	Basesystem	Assignee:	Johannes Meixner <jsmeix>
Status:	RESOLVED FIXED	QA Contact:	E-mail List <qa-bugs>
Severity:	Minor
Priority:	P5 - None
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	SUSE Other
Whiteboard:
Found By:	Other	Services Priority:
Business Priority:		Blocker:	---
Marketing QA Status:	---	IT Deployment:	---

Description David Binderman 2006-01-06 19:44:57 UTC

I just tried to compile package sane-frontends-1.0.14-2 with a non standard
version of the GNU C compiler

It said

xcam.c:1290: warning: array subscript out of range

The source code is

	testfilename[sizeof (testfilename)] = 0;

Clearly broken code. Suggest 

	testfilename[sizeof (testfilename) - 1] = 0;

Comment 1 Johannes Meixner 2006-01-09 13:49:53 UTC

*** Bug 134418 has been marked as a duplicate of this bug. ***

Comment 2 Johannes Meixner 2006-01-17 16:06:54 UTC

Fixed package submitted to STABLE.

Comment 3 Johannes Meixner 2006-01-18 09:25:21 UTC

FYI: Also fixed upstream:
http://lists.alioth.debian.org/pipermail/sane-devel/2006-January/015946.html

Comment 4 David Binderman 2006-03-24 21:14:31 UTC

(In reply to comment #3)
> FYI: Also fixed upstream:

Strange. It seems to be still broken a couple of months
later in Suse Factory.

I am not sure how this has happened.

Comment 5 Johannes Meixner 2006-03-27 14:05:53 UTC

Argl!
You are right!
I fixed it only in xscanimage.c according to bug #134418
because I simply missed that this bug is about xcam.c!
Sorry!
Will fix it also for xcam.c.

Comment 6 Johannes Meixner 2006-03-27 14:17:55 UTC

Fixed and submitted to STABLE.