Bug 143348

I'll add the xkb khmer keyboard layout. It's new in CVS.

Yes the keyboard layout is new in CVS. But there is a small problem left, because it is not enough to just add the layout. There need to be some lines in the Compose files in order to type some special Khmer character which are composed of two characters. 

Please see also: https://bugs.freedesktop.org/show_bug.cgi?id=5389

AFAIK this is not in CVS yet, mainly because I could not find the correct place for the bug report yet. 

There is also the issue that Gnome has hardcoded the compose information and does not use the Compose files at all. I hope that I will find time to take care about this in the near future. 

Please also have in mind when you add the Khmer layout that this can not replace the English layout. Almost all keyboards in Cambodia have English layout but there are almost no Latin keys in the Khmer layout. So what is needed for the installation is a mixed keyboard with English and Khmer in two groups together with group switching via alt+shift. 

In KDE and Gnome it is possible to use the keyboard configuration tools to set up the mixed keyboard but I have never seen a possibility during installation. 

The compose files are not in xkeyboard-config project, but in X.Org project. The correct place to file a bugreport is also bugs.freedesktop.org, but product xorg instead of xkeyboard-config. The Compose file for UTF-8 locales
(our default) is /usr/X11R6/lib/X11/locale/en_US.UTF-8/Compose.

I've added now xkb khmer keyboad support for Beta1. Please provide the required changes (patch) for the Compose file. Thanks.

You are very quick :-)
I do not know how to attach files here so I put the information there:

http://www.khmeros.info/download/Compose.addition

These lines needs to get added to _all_ locale with UTF-8 Compose files. Only for en_US.UTF-8 is not enough because we have in Cambodia people from other Asian countries who might use other locale. 

We are using the same Compose file for all locales.

<U17ff> :       "ាំ"
<U17fe> :       "ោះ"
<U17fd> :       "េះ"
<U17fc> :       "ុំ"
<U17fb> :       "ុះ"

Are you sure adding this to Compose file can work? Did you try this? The syntax looks different from the one of other lines in Compose file.

> We are using the same Compose file for all locales.

Oh, this must be a change from Suse 10 to 10.1?
On my computer I have Compose files in pt_BR.UTF-8, ja_JP.UTF-8, ko_KR.UTF-8 and many other UTF-8 locale folder?


> <U17ff> :       "ាំ"
> <U17fe> :       "ោះ"
> <U17fd> :       "េះ"
> <U17fc> :       "ុំ"
> <U17fb> :       "ុះ"
> 
> Are you sure adding this to Compose file can work? Did you try this? 

Yes it works! We are using this since many months already. It works on Suse 9.3 and Suse 10, other Suse versions were not tested. It also works with Ubuntu and Fedora Core 4.

> The syntax looks different from the one of other lines in Compose file.

Yes, because the other entries use the file for the opposite purpose: combining keystrokes to one character. 
But we are using it for creating two characters from one keystroke. 

Indeed. Adding the proposed lines to a Compose file works. I'll add them to our UTF-8 Compose files.

Compose related changes done for Beta2.

Uhm... was there any update of "kbd" also? If not, I probably cannot add new keyaborad layout to YaST.

No, I don't think there is any khmer keyboard layout available for the Linux console.

jsuchome> Uhm... was there any update of "kbd" also?

No, on the console only bitmap fonts are possible currently and we
were told that there are no suitable bitmap fonts for Khmer, therefore
there is currently no chance for Khmer to work on the console.

There are no Khmer bitmap fonts and AFAIK there will never be. Khmer is a kind of Indic language in the writing system. It depends heavily on reordering and stacking of characters hence complex script support in the render engine with open type tables. I do not see any possibility to do this with bitmap fonts. 

Because of this we never thought about a Khmer keyboard for the console. 

The Khmer X keyboard includes only a few of the Latin characters, it is not possible to type ascii with it. You always need to switch to an English keyboard for this. 

In case keyboard switching is possible in Yast and you see a need for a keyboard for the console I can try to create one.

I think the default keyboard for Cambodia for Yast in console mode should be English because almost all computer here have an English keyboard layout.

> I think the default keyboard for Cambodia for Yast in console mode should be
> English because almost all computer here have an English keyboard layout.

That's fine for me.

I would like to upstream those. For this I need a 'signed off by' the author. Please provide this.
All patches which cannot be upstreamed and are not crucial for the openSUSE or SLE environment will eventually get dropped.

Please assign to me when done.

I am not sure how I can "sign off" this. What do I need to do?

I would be very happy if you could upstream this.

BTW, X11 khmer keyboard layout is already upstreamed. :-)

I'm attaching the patches we currently use for libX11. We would need a signed-off for the patches by you.

Created attachment 430797 [details]
p_khmer-compose.diff

Created attachment 430798 [details]
p_khmer-locale.diff

(In reply to comment #17)
> I am not sure how I can "sign off" this. What do I need to do?
> 
> I would be very happy if you could upstream this.

Ok, I just would like to know if the patches are from you or anyone you know who will allow to put them upstream.
Then I will add an:
Signed-off-by: Jens Herden <jens.herden@email.de>
to the commit message of the patch and we are good :)

I only created the 4 lines for the compose files. 
Stefan Dirsch made patches from them, see comment #8. 
I do not really understand the patches in detail and I have no time to look into this yet.
But OpenSuse is used a lot in Cambodia, so the patches are fine!

So go ahead and use my name to sign-off the patch.

Ok, I'm going to name you as the author of the patch and take your comment as permission to push this upstream. 
Jens, Thanks a lot!