Bug 143352

Summary: mount hotplug option not working
Product: [openSUSE] SUSE Linux 10.1 Reporter: Stefan Scheler <sscheler>
Component: BasesystemAssignee: Stefan Scheler <sscheler>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Beta 2   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 131547    
Attachments: fix

Description Stefan Scheler 2006-01-16 13:00:47 UTC 
The mount hotplug option is not working since util-linux-2.12r.
Comment 1 Stefan Scheler 2006-01-27 12:15:47 UTC 
The kernel doesn't know about MS_HOTPLUG and reports EINVAL in the mount syscall. That's why the present hotplug option patch does not work any longer. And because the kernel actually doesn't need to know this option, I removed the flag from the mount syscall in mount.c.
Comment 2 Stefan Scheler 2006-01-27 12:17:12 UTC 
Created attachment 65386 [details]
fix
Comment 3 Christian Zoz 2006-01-27 14:15:46 UTC 
Did you submit a fixed package?

If not, please do so and resolve this bug.
Comment 4 Stefan Scheler 2006-01-28 09:07:06 UTC 
yes, it's fixed in STABLE.
Comment 5 Chris L Mason 2006-02-01 01:14:35 UTC 
-       ret = mount (args->spec, args->node, args->type, flags, args->data);
+       /* don't pass MS_HOTPLUG to the kernel (Bug: 143352) */
+       ret = mount (args->spec, args->node, args->type, flags & !MS_HOTPLUG, args->data);

flags & !MS_HOTPLUG will always be zero.
Comment 6 Chris L Mason 2006-02-01 01:26:22 UTC 
ok, fix checked in.
Comment 7 Ruediger Oertel 2006-02-01 01:28:19 UTC 
!MS_HOTPLUG is 0
~MS_HOTPLUG is probably what was wanted ...