Bug 143496

Summary: NetworkManager: wpa_supplicant started with uninitialized argv
Product: [openSUSE] SUSE Linux 10.1 Reporter: Forgotten User ZhJd0F0L3x <forgotten_ZhJd0F0L3x>
Component: NetworkAssignee: Robert Love <rml>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None    
Version: Beta 1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Component Test Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---
Bug Depends on:    
Bug Blocks: 140732    
Attachments: fix

Description Forgotten User ZhJd0F0L3x 2006-01-17 14:05:13 UTC
ps shows:
27850 ? S 0:00 /usr/sbin/wpa_supplicant -g /var/run/wpa_supplicant-global ?0

the "?0" changes with every start.
this is a simple typo (will also attach the patch):

--- src/nm-device-802-11-wireless.c     2006-01-17 14:30:24.000000000 +0100
+++ src/nm-device-802-11-wireless.c~    2006-01-17 14:38:36.000000000 +0100
@@ -2404,15 +2404,15 @@ supplicant_exec (NMDevice80211Wireless *
        char *  argv[4];
        GError *        error = NULL;
        GPid            pid = -1;

        argv[0] = WPA_SUPPLICANT_BINARY;
        argv[1] = "-g";
        argv[2] = WPA_SUPPLICANT_GLOBAL_SOCKET;
-       argv[4] = NULL;
+       argv[3] = NULL;

        if (!(success = g_spawn_async ("/", argv, NULL, 0, NULL, NULL, &pid, &error)))
        {
                if (error)
                {
                        nm_warning ("Couldn't start wpa_supplicant.  Error: (%d) %s",
                                        error->code, error->message);

to quote Marcus Meissner:
(14:36:22) _Marcus_:   das haette evt -fstack-protector gefunden ;)
translated: "this would eventually be caught by -fstack-protector ;)"
Comment 1 Forgotten User ZhJd0F0L3x 2006-01-17 14:11:48 UTC
Created attachment 63610 [details]
fix
Comment 2 Robert Love 2006-01-17 15:20:53 UTC
Good catch, thanks!

Checked into CVS and will fall into the next autobuild submission.
Comment 3 Robert Love 2006-01-17 16:20:54 UTC
Fixed.