Bug 144651

Summary: deprecated ioctl usage in pcmciautils
Product: [openSUSE] SUSE Linux 10.1 Reporter: Andreas Jaeger <aj>
Component: HotplugAssignee: Christian Zoz <zoz>
Status: RESOLVED INVALID QA Contact: E-mail List <qa-bugs>
Severity: Major    
Priority: P5 - None CC: ro
Version: Beta 1   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Andreas Jaeger 2006-01-22 14:44:57 UTC 
plugging my pcmcia CF card holder into my laptop, I see the following in dmesg:

pcmcia: registering new device pcmcia0.0
Probing IDE interface ide2...
hde: SanDisk SDCFH-1024, CFA DISK drive
ide2 at 0x3100-0x3107,0x310e on irq 3
hde: max request size: 128KiB
hde: 2001888 sectors (1024 MB) w/1KiB Cache, CHS=1986/16/63
 hde: hde1
ide-cs: hde: Vcc = 3.3, Vpp = 0.0
pcmcia: Detected deprecated PCMCIA ioctl usage.
pcmcia: This interface will soon be removed from the kernel; please expect breakage unless you upgrade to new tools.
pcmcia: see http://www.kernel.org/pub/linux/utils/kernel/pcmcia/pcmcia.html for details.
subfs 0.9

I'm concerned about the "detected deprecated PCMCIA ioctl usage".

I noticed that pcmciautils 0.12 is out and contains according to the Changelog (http://www.kernel.org/pub/linux/utils/kernel/pcmcia/ChangeLog-01) this patch:
commit ff98d8b9f231b35d5060905048f929b2fcfa099d
Author: Dominik Brodowski <linux@dominikbrodowski.net>
Date:   Sun Dec 18 13:37:50 2005 +0100

    [PATCH] pccardctl: do not use deprecated sysfs_read_attribute_value()
    
    sysfs_read_attribute_value() is no longer available in libsysfs-2.0.0,
    therefore re-structure the code to use sysfs_read_attribute().

Should we backport this patch or upgrade pcmciautils?
Comment 1 Christian Zoz 2006-01-27 14:09:56 UTC 
deprectaed ioctl != deprecated libsysfs function.

This is a problem in the driver, but is not severe now since the deprecated ioctl is still there. I guess most drivers will be fixed upstream in time.
==> INVALID

But:
I have a pcmciautils-012 package ready. Do you want me to submit it? There is nothing really important. Even the changed libsysfs usage is irrevelavt since we still have libsysfs-1.0.3. On the other hand it should not harm. It is out since december and seems not to have severe bugs.

Should i submit it?
Comment 2 Andreas Jaeger 2006-01-27 15:25:55 UTC 
Thorsten, ok to take it?

Christian, submit it.
Comment 3 Thorsten Kukuk 2006-01-28 13:52:29 UTC 
Ok for me.
Comment 4 Christian Zoz 2006-01-30 09:53:37 UTC 
submitted.

nevertheless, the initial bug is invalid.