Bug 145895

Summary: ampache is broken
Product: [openSUSE] SUSE Linux 10.1 Reporter: Peter Poeml <poeml>
Component: OtherAssignee: Petr Ostadal <postadal>
Status: RESOLVED FIXED QA Contact: E-mail List <qa-bugs>
Severity: Normal    
Priority: P5 - None CC: crrodriguez, postadal
Version: Beta 2   
Target Milestone: ---   
Hardware: Other   
OS: Other   
Whiteboard:
Found By: Other Services Priority:
Business Priority: Blocker: ---
Marketing QA Status: --- IT Deployment: ---

Description Peter Poeml 2006-01-26 16:25:41 UTC
[Thu Jan 26 17:06:47 2006] [error] [client 195.135.221.2] PHP Fatal error:  Call to undefined function check_sess_db() in /srv/www/ampache/modules/init.php on line 203
Comment 1 Peter Poeml 2006-01-31 07:37:23 UTC
This is caused by a new default in php5, compared to php4:

; Allow the <? tag.  Otherwise, only <?php and <script> tags are recognized.
; NOTE: Using short tags should be avoided when developing applications or
; libraries that are meant for redistribution, or deployment on PHP
; servers which are not under your control, because short tags may not
; be supported on the target server. For portable, redistributable code,
; be sure not to use short tags.
short_open_tag = Off


ampache works with 
	php_value short_open_tag On
in the apache config.


Other php applications might break with the new default as well... Petr,
do you think the default should be reverted, for compatibility?
Comment 2 Cristian Rodríguez 2006-01-31 07:59:14 UTC
should'nt harm reverting the short_open_tag  setting to On.

there are still a lot of broken code using short tags out there..**sigh**

Comment 3 Cristian Rodríguez 2006-01-31 08:18:44 UTC
BTW.. 

Poeml : a little correction :) 
apache directive for that is

php_flag short_open_tag On 

in htaccess

and php_admin_flag short_open_tag On

in httpd.conf

not php_value 

;)

ps:voted in favor of the proposed change to the default PHP config,and I'll sumbit a patch to ampache upstream to get short-tags removed. (trivial) 



Comment 4 Peter Poeml 2006-01-31 09:02:35 UTC
Thanks for your help!
What is the difference between php_value and php_admin_flag?
Comment 5 Petr Ostadal 2006-01-31 13:10:56 UTC
fixed and submited to STABLE (thx Cristian)
Comment 6 Cristian Rodríguez 2006-01-31 16:08:58 UTC
Poeml  php_value should be used only for non bool settings.

http://cl.php.net/manual/en/ini.core.php

additionaly using php_admin_flag (can be used only in httpd.conf) mean the user cannot overrride ht perticular setting , via .htaccess.

http://www.php.net/manual/en/configuration.changes.php

;-)
Comment 7 Peter Poeml 2006-01-31 17:21:37 UTC
Thank you for the explanation!

I removed the change in ampache now, since the default in php5 has been
reverted.