|
Bugzilla – Full Text Bug Listing |
| Summary: | Qt 4.10 which is made available for SUSE 10.0 must be the GPL-licenced version | ||
|---|---|---|---|
| Product: | [openSUSE] SUSE LINUX 10.0 | Reporter: | Forgotten User bwNirt9brK <forgotten_bwNirt9brK> |
| Component: | Other | Assignee: | E-mail List <kde-maintainers> |
| Status: | RESOLVED FIXED | QA Contact: | E-mail List <qa-bugs> |
| Severity: | Normal | ||
| Priority: | P5 - None | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | i686 | ||
| OS: | SuSE Linux 10.0 | ||
| Whiteboard: | |||
| Found By: | Other | Services Priority: | |
| Business Priority: | Blocker: | --- | |
| Marketing QA Status: | --- | IT Deployment: | --- |
|
Description
Forgotten User bwNirt9brK
2006-01-30 13:52:54 UTC
Confirmed for Qt Designer 4.10 from package qt-devel. Version 3.3.5 in package qt3-devel-tools has the double license in its "About" dialog. Reassigning to KDE maintainers... The code creating the about box is wrong, the license _IS_ GPL. If you download qt 4.1 yourself, it will have the same bug. The code creating the about box is not wrong. If you will open and see: qt-x11-opensource-src-4.1.0.tar.gz/qt-x11-opensource-src-4.1.0/tools/designer/src/designer/versiondialog.cpp it has: #if defined(QT_OPENSOURCE) "This version of Qt Designer is part of the Qt Open Source Edition, for use " "in the development of Open Source applications. " "Qt is a comprehensive C++ framework for cross-platform application " "development.<br/><br/>" "You need a commercial Qt license for development of proprietary (closed " "source) applications. Please see <tt>http://www.trolltech.com/company/model" ".html</tt> for an overview of Qt licensing.<br/>" #else "This program is licensed to you under the terms of the " "Qt Commercial License Agreement. For details, see the file LICENSE " "that came with this software distribution.<br/>" #endif It looks like a #define QT_OPENSOURCE is in order. no, its really an upstream bug. the buildsystem is supposed to set QT_OPENSOURCE itself: src/qbase.pri: contains(QT_PRODUCT, OpenSource.*):DEFINES *= QT_OPENSOURCE the problem is that QT_PRODUCT is undefined, because the key has been renamed to QT_EDITION, but this check wasn't fixed. we've reported it upstream and are just waiting for them to sort it out. added upstream patch to the package. Where can I download the fixed package please? Even the mother download site: ftp://ftp.suse.com/pub/suse/i386/supplementary/KDE/update_for_10.0/development seems to have the same (buggy) package as I have downloaded (judging by the build number of qt-4.1.0-3.i586.rpm). It will appear there once our build server builds supplementary packages again after current maintenance phase and the tree is synced to outside again. Judging from the fact that KDE 3.51 packages are out, it appears that the build server is back on track. Sorry if I am nagging but may I just remind that the concerned package is not yet updated? Look again tomorrow. (In reply to comment #4) > src/qbase.pri: > contains(QT_PRODUCT, OpenSource.*):DEFINES *= QT_OPENSOURCE > > the problem is that QT_PRODUCT is undefined, because the key has > been renamed to QT_EDITION, but this check wasn't fixed. I've downloaded the latest qt-4.1.1 src tgz from Trolltech and the file has the same line in src/qbase.pri: contains(QT_PRODUCT, OpenSource.*):DEFINES *= QT_OPENSOURCE Where was it renamed to QT_EDITION and where was it corrected by Trolltech? Can you please attach the patch that you got from upstream? Thanks. |